Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana server should not rendering directory listings #6760

Closed
epixa opened this issue Apr 4, 2016 · 5 comments
Closed

Kibana server should not rendering directory listings #6760

epixa opened this issue Apr 4, 2016 · 5 comments

Comments

@epixa
Copy link
Contributor

epixa commented Apr 4, 2016

The Kibana server should not render directory listings:

screen shot 2016-04-04 at 10 47 08 am

If someone really wants to expose a directory for the sake of sharing its contents, they should do so via their reverse proxy.

@vicvega
Copy link

vicvega commented Apr 5, 2016

@spalger, why did you make this setting configurable?
I mean why someone should need to enable directory listing? I can't see any reason

@epixa
Copy link
Contributor Author

epixa commented Apr 5, 2016

I also can't imagine why someone would need this, but like it or not, the feature does exist at the moment. If we remove it outright, then we might be removing a feature that someone has come to rely on.

@spalger
Copy link
Contributor

spalger commented Apr 5, 2016

The reason I like directory listings is because it lets you figure out what files are available when you don't have access to the file system for whatever reason. This might sound like a security issue, and if you don't want people to know what assets are available you would be "right", but I think there are perfectly valid reasons to expose this information and totally non-malicious reasons you would want this information.

By turning it on only in dev people can use it while writing plugins but... I'm open to disabling it completely.

I think there is a good reason this is generally a default behavior of static file servers though.

@vicvega
Copy link

vicvega commented Apr 5, 2016

We are using a ES cluster secured by shield to protect sensitive data and that /bundles/ directory is exposed without any authentication.
I know those are just public static assets, and it is not a real security issue, but it smells like it...

I'd suggest to let it configurable, but at least disabled by default

@spalger
Copy link
Contributor

spalger commented Apr 5, 2016

Cool, it is configurable and disabled by default in "production" mode, the default mode. If you set the kibana environment to "development" then this will turn on too, but there's no reason for users to do that.

tkajtoch added a commit that referenced this issue May 18, 2023
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this issue May 25, 2023
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([elastic#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([elastic#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([elastic#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([elastic#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([elastic#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([elastic#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([elastic#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([elastic#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants