Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add logoVulnerabilityManagement #6763

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented May 9, 2023

Summary

Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.

Adding the logo vulnerability management icon for CNVM integration

image Screen Shot 2023-05-09 at 9 54 49 AM

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs (using @default if default values are missing) and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@Omolola-Akinleye Omolola-Akinleye marked this pull request as ready for review May 9, 2023 20:17
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6763/

@andreadelrio andreadelrio changed the title add logo for vulnerability management app [EuiIcon] Add logoVulnerabilityManagement May 9, 2023
@Omolola-Akinleye
Copy link
Contributor Author

Hi andreadelrio, sure here is the figma link.

@elastic elastic deleted a comment from andreadelrio May 10, 2023
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Omolola-Akinleye nit: you just have a typo on the SVG file name, please fix.

@Omolola-Akinleye
Copy link
Contributor Author

Omolola-Akinleye commented May 10, 2023

Nice catch! Updated file name. Thanks, @andreadelrio

@Omolola-Akinleye Omolola-Akinleye enabled auto-merge (squash) May 10, 2023 21:46
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6763/

@Omolola-Akinleye Omolola-Akinleye merged commit 3e929d2 into elastic:main May 10, 2023
tkajtoch added a commit to elastic/kibana that referenced this pull request May 18, 2023
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([elastic#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([elastic#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([elastic#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([elastic#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([elastic#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([elastic#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([elastic#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([elastic#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants