Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serverless] Create the Serverless Plugin #155582

Merged
merged 13 commits into from
Apr 26, 2023
Merged

[serverless] Create the Serverless Plugin #155582

merged 13 commits into from
Apr 26, 2023

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Apr 24, 2023 •
edited by kibanamachine
Loading

Derived from #153274 for production.

Summary

This PR creates the serverless plugin for Kibana Serverless projects.

image

It uses the methodology proven out in the proof-of-concept (#153274) and prepares it for production:

  • Adds chrome style and related API to the chrome services.
  • Creates the serverless plugin.
  • Invokes the new chrome style API for all serverless projects.
  • Alters yarn scripts to support all project types, and switching between them.
  • Creates the new "Project Switcher" component for use in the new chrome header for Serverless.
  • Creates a Storybook config for this and future components.
  • Adds API endpoint to trigger project switching and Watcher restarts.

Screenshot 2023-04-26 at 10 44 01 AM

Next steps

@clintandrewhall clintandrewhall added review loe:large Large Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) ci:build-storybooks Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels Apr 24, 2023
@clintandrewhall clintandrewhall requested review from a team as code owners April 24, 2023 03:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@github-actions
Copy link
Contributor

Documentation preview:

@clintandrewhall clintandrewhall mentioned this pull request Apr 24, 2023
Merged
jbudz
jbudz approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml / storybook aliases

semd
semd approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Security Solution requirements

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 417 423 +6
serverless - 15 +15
total +21

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-chrome-browser 46 47 +1
@kbn/serverless-project-switcher - 7 +7
serverless - 6 +6
total +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 145.5KB 145.5KB +12.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/serverless-project-switcher - 1 +1
@kbn/serverless-types - 1 +1
total +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 353.1KB 360.9KB +7.7KB
security 61.2KB 61.3KB +137.0B
serverless - 4.9KB +4.9KB
total +12.8KB
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-browser 120 124 +4
@kbn/serverless-project-switcher - 10 +10
@kbn/serverless-storybook-config - 2 +2
serverless - 7 +7
total +23

ESLint disabled in files

id before after diff
@kbn/serverless-storybook-config - 1 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
serverless - 4 +4
total +9

Total ESLint disabled count

id before after diff
@kbn/serverless-storybook-config - 1 +1
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
serverless - 4 +4
total +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 8e37b38 into elastic:main Apr 26, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.9 The branch "8.9" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 155582

Questions ?

Please refer to the Backport tool documentation

@lukeelmers lukeelmers mentioned this pull request Apr 27, 2023
Merged
1 task
This was referenced Apr 27, 2023
Merged
Merged
Merged
clintandrewhall added a commit that referenced this pull request May 1, 2023
@clintandrewhall @kibanamachine
[serverless] Create Observability Serverless plugin (#156118)
4e88645 
> Derived from #153274
> Builds upon #155582

## Summary

This PR creates the Serverless Observability plugin, based on the work
from #153274:

- creates the plugin,
- adds API to hide the solution navigation from Enterprise Search,
- calls that API if the chrome style is `project`.

<img width="1610" alt="Screenshot 2023-04-27 at 5 03 44 PM"
src="https://user-images.githubusercontent.com/297604/234990765-d6770650-41b3-4e94-ad7f-c6a22778d39a.png">

---------

Co-authored-by: kibanamachine <[email protected]>
clintandrewhall added a commit that referenced this pull request May 2, 2023
@clintandrewhall @kibanamachine
[serverless] Create Security Serverless plugin (#156104)
b217dbf 
> Derived from #153274
> Builds upon #155582

## Summary

This PR creates the Serverless Security plugin, based on the work from
#153274:

- creates the plugin,
- adds API to hide the solution navigation from Security,
- calls that API if the chrome style is `project`.

<img width="1688" alt="Screenshot 2023-04-27 at 12 37 46 PM"
src="https://user-images.githubusercontent.com/297604/234979670-425bfb12-8194-4916-8f92-efff7804b577.png">

## Next Steps

- render the left nav from #153274
using an API provided by @elastic/appex-sharedux
  - this low-level API should be coming in the next few days.

---------

Co-authored-by: kibanamachine <[email protected]>
@jeramysoucy jeramysoucy mentioned this pull request Jan 25, 2024
Merged
jeramysoucy added a commit that referenced this pull request Jan 26, 2024
@jeramysoucy
Reverts erroneous addition of security plugin enabled config option (#…
4385dc1 
…175565)

## Summary

In #155582, an `enabled` option was added to the `Security` plugin. This
option is not supported or documented. This PR reverts that change.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2024
@jeramysoucy
Reverts erroneous addition of security plugin enabled config option (e…
debc6d4 
…lastic#175565)

## Summary

In elastic#155582, an `enabled` option was added to the `Security` plugin. This
option is not supported or documented. This PR reverts that change.

(cherry picked from commit 4385dc1)
kibanamachine added a commit that referenced this pull request Jan 26, 2024
@kibanamachine @jeramysoucy
[8.12] Reverts erroneous addition of security plugin enabled config o…
5535353 
…ption (#175565) (#175692)

# Backport

This will backport the following commits from `main` to `8.12`:
- [Reverts erroneous addition of security plugin enabled config option
(#175565)](#175565)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-26T15:16:03Z","message":"Reverts
erroneous addition of security plugin enabled config option
(#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added
to the `Security` plugin. This\r\noption is not supported or documented.
This PR reverts that
change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-minor","v8.13.0"],"title":"Reverts
erroneous addition of security plugin enabled config
option","number":175565,"url":"https://github.com/elastic/kibana/pull/175565","mergeCommit":{"message":"Reverts
erroneous addition of security plugin enabled config option
(#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added
to the `Security` plugin. This\r\noption is not supported or documented.
This PR reverts that
change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175565","number":175565,"mergeCommit":{"message":"Reverts
erroneous addition of security plugin enabled config option
(#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added
to the `Security` plugin. This\r\noption is not supported or documented.
This PR reverts that
change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@jeramysoucy @CoenWarmer
Reverts erroneous addition of security plugin enabled config option (e…
b115688 
…lastic#175565)

## Summary

In elastic#155582, an `enabled` option was added to the `Security` plugin. This
option is not supported or documented. This PR reverts that change.
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 24, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

6 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155582 locally

@clintandrewhall clintandrewhall added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 3, 2024
@clintandrewhall clintandrewhall deleted the serverless/plugin branch September 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

@semd semd semd approved these changes

@jbudz jbudz jbudz approved these changes

@sebelga sebelga sebelga approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-storybooks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@clintandrewhall @elasticmachine @kibana-ci @kibanamachine @ryankeairns @sebelga @jbudz @semd @jeramysoucy