Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless] Create Observability Serverless plugin #156118

Merged

Conversation

clintandrewhall
Copy link
Contributor

Derived from #153274
Builds upon #155582

Summary

This PR creates the Serverless Observability plugin, based on the work from #153274:

  • creates the plugin,
  • adds API to hide the solution navigation from Enterprise Search,
  • calls that API if the chrome style is project.

Screenshot 2023-04-27 at 5 03 44 PM

@clintandrewhall clintandrewhall added review loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels Apr 27, 2023
@clintandrewhall clintandrewhall requested a review from a team April 27, 2023 21:04
@clintandrewhall clintandrewhall requested review from a team as code owners April 27, 2023 21:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@github-actions
Copy link
Contributor

Documentation preview:

@CoenWarmer CoenWarmer self-requested a review April 28, 2023 13:07
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the changes to the page template should only be applied on Observability Shared.

@clintandrewhall clintandrewhall enabled auto-merge (squash) April 28, 2023 15:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessObservability - 4 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 142 143 +1
serverlessObservability - 6 +6
total +7

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 21.0KB 21.3KB +314.0B
serverlessObservability - 1.5KB +1.5KB
total +1.9KB
Unknown metric groups

API count

id before after diff
observabilityShared 142 143 +1
serverlessObservability - 6 +6
total +7

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
serverlessObservability - 4 +4
total +9

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
serverlessObservability - 4 +4
total +9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clintandrewhall clintandrewhall merged commit 4e88645 into elastic:main May 1, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants