Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless] Create Search Serverless plugin #156037

Merged

Conversation

clintandrewhall
Copy link
Contributor

Derived from #153274
Builds upon #155582

Summary

This PR creates the Serverless Search plugin, based on the work from #153274:

  • creates the plugin,
  • adds API to hide the solution navigation from Enterprise Search,
  • calls that API if the chrome style is project.
  • nit: fixes warnings from eslint in the files this PR touched.

Screenshot 2023-04-27 at 11 36 49 AM

Next Steps

@clintandrewhall clintandrewhall added review loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:EnterpriseSearch Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels Apr 27, 2023
@clintandrewhall clintandrewhall requested a review from a team April 27, 2023 15:37
@clintandrewhall clintandrewhall requested a review from a team as a code owner April 27, 2023 15:37
@clintandrewhall clintandrewhall requested a review from a team April 27, 2023 15:37
@clintandrewhall clintandrewhall added the release_note:skip Skip the PR/issue when compiling release notes label Apr 27, 2023
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall, one question on CODEOWNERS

.github/CODEOWNERS Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch - 4 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
enterpriseSearch 7 9 +2
serverlessSearch - 6 +6
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +111.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 31.5KB 31.7KB +194.0B
serverlessSearch - 1.5KB +1.5KB
total +1.7KB
Unknown metric groups

API count

id before after diff
enterpriseSearch 7 9 +2
serverlessSearch - 6 +6
total +8

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
serverlessSearch - 4 +4
total +9

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
serverlessSearch - 4 +4
total +9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 965b327 into elastic:main Apr 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 28, 2023
@clintandrewhall clintandrewhall deleted the serverless/search-project-plugin branch April 28, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:EnterpriseSearch Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants