profiling: fix setup page and instructions #150885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inge4pres
added
ci:build-cloud-image
ci:cloud-deploy
inge4pres
added
release_note:skip
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
from
1627148 to
6801ad9
Compare
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
from
6801ad9 to
69d9620
Compare
rockdaboot
reviewed
Feb 10, 2023
| @@ -124,7 +124,8 @@ docker.elastic.co/observability/profiling-agent:stable /root/pf-host-agent \\ | |||
| }), | |||
| content: ( | |||
| <EuiCodeBlock paddingSize="s" isCopyable> | |||
| wget -O- https://releases.prodfiler.com/stable/pf-host-agent_linux_amd64.tgz | tar xz | |||
| wget -O pf-host-agent.tgz "https://ela.st/pf-host-agent-amd64" && tar xzf | |||
There was a problem hiding this comment.
Can you explain why you changed this ?
There was a problem hiding this comment.
It's been requested in https://github.com/elastic/prodfiler/issues/2961#issue-1574328032
There was a problem hiding this comment.
Hm, it has been requested without giving a reason. Would be interesting to know. Maybe some OSX or zsh incompatibility ? Do you remember or can you find out ?
There was a problem hiding this comment.
Maybe there's a misunderstanding here 😄
The major change here is the use of a different URL, a redirect.
The redirect URL does not have a file extension, so the downloaded file piped into tar would fail.
Aside from the URL, we mainly changed the wget option to download to a file instead of STDOUT.
There was a problem hiding this comment.
When you pipe the wget output to tar, you don't need any file extension.
Just try it out yourself:
wget -O- https://ela.st/pf-host-agent-amd64 | tar xz
works like a charm without having to store an intermediate file.
|
Can you add two screenshots (before / after) ? I am not sure where to look at atm (running Kibana with your branch locally). |
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
from
69d9620 to
b8d53a6
Compare
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
from
b8d53a6 to
a454f40
Compare
dgieselaar
reviewed
Feb 13, 2023
|
Just posting the latest updates in this PR Before / After |
boriskirov
approved these changes
Feb 13, 2023
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
5 times, most recently
from
810dec9 to
c351b81
Compare
Signed-off-by: inge4pres <[email protected]>
…-ref HEAD~1..HEAD --fix'
inge4pres
force-pushed
the
profiling/update-onboarding-instructions
branch
from
6d63aa1 to
0d8a649
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @inge4pres |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2023
Resolves elastic/prodfiler#2961. We update the setup information text instructions to add data for Universal Profiling Beta. Signed-off-by: inge4pres <[email protected]> Co-authored-by: boriskirov <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 560c3b9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 15, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [profiling: fix setup page and instructions (#150885)](#150885) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Francesco Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-15T10:50:29Z","message":"profiling: fix setup page and instructions (#150885)\n\nResolves https://github.com/elastic/prodfiler/issues/2961.\r\nWe update the setup information text instructions to add data for\r\nUniversal Profiling Beta.\r\n\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: boriskirov <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","8.7 candidate","ci:build-cloud-image","ci:cloud-deploy","ci:cloud-redeploy","v8.7.0","v8.8.0"],"number":150885,"url":"https://github.com/elastic/kibana/pull/150885","mergeCommit":{"message":"profiling: fix setup page and instructions (#150885)\n\nResolves https://github.com/elastic/prodfiler/issues/2961.\r\nWe update the setup information text instructions to add data for\r\nUniversal Profiling Beta.\r\n\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: boriskirov <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150885","number":150885,"mergeCommit":{"message":"profiling: fix setup page and instructions (#150885)\n\nResolves https://github.com/elastic/prodfiler/issues/2961.\r\nWe update the setup information text instructions to add data for\r\nUniversal Profiling Beta.\r\n\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: boriskirov <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76"}}]}] BACKPORT--> Co-authored-by: Francesco Gualazzi <[email protected]>
justinkambic
pushed a commit
to justinkambic/kibana
that referenced
this pull request
Feb 23, 2023
Resolves elastic/prodfiler#2961. We update the setup information text instructions to add data for Universal Profiling Beta. Signed-off-by: inge4pres <[email protected]> Co-authored-by: boriskirov <[email protected]> Co-authored-by: kibanamachine <[email protected]>
3 tasks
jbcrail
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: inge4pres <[email protected]> ## Summary Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling. ### Checklist - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Related issues or PRs * #155642 * #150885 --------- Signed-off-by: inge4pres <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Jen Huang <[email protected]>
kibanamachine
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: inge4pres <[email protected]> ## Summary Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling. ### Checklist - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Related issues or PRs * #155642 * #150885 --------- Signed-off-by: inge4pres <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Jen Huang <[email protected]> (cherry picked from commit d4f6cf7)
kibanamachine
referenced
this pull request
May 2, 2023
) # Backport This will backport the following commits from `main` to `8.8`: - [Profiling: symbolization created on user opt-in (#156089)](#156089) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Francesco Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T18:24:54Z","message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","ci:build-cloud-image","8.8 candidate","v8.8.0","v8.9.0"],"number":156089,"url":"https://github.com/elastic/kibana/pull/156089","mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156089","number":156089,"mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}}]}] BACKPORT--> Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: inge4pres [email protected]
Summary
Resolves https://github.com/elastic/prodfiler/issues/2961.
We update the setup information text instructions to add data for Universal Profiling Beta.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Please test in Cloud using the build from CI.