Profiling: symbolization created on user opt-in #156089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
inge4pres
added
backport
8.8 candidate
ci:build-cloud-image
release_note:skip
jen-huang
reviewed
Apr 27, 2023
| package: { | ||
| name: 'profiler_symbolizer', | ||
| title: 'Universal Profiling Symbolizer', | ||
| version: '8.8.0-preview', |
There was a problem hiding this comment.
you could consider omitting this field altogether, this will make it always install the latest symbolizer package it finds (including prerelease packages) that is compatible with this version of Kibana
this means that this version field will not need to be manually update for later releases, including patches. but it also means care should be given as to not accidentally release a package incorrectly (i.e. publishing a 8.9.0 without a >8.9.0 kibana version constraint)
There was a problem hiding this comment.
Ah thanks 👍🏼 TIL
I'll discuss this with the team and eventually update the PR accordingly after testing.
There was a problem hiding this comment.
@jen-huang whan you say omitting this field i suppose you mean not setting package at all? Or does it mean leaving it as an empty object o null?
There was a problem hiding this comment.
Apparently this commit broke the tests... I'll remove it and re-run them
There was a problem hiding this comment.
I only meant removing version: '8.8.0-preview', line :)
There was a problem hiding this comment.
Ah thanks, good to know 😄
Will keep in mind for the next PR 👍🏼
jen-huang
reviewed
Apr 28, 2023
x-pack/plugins/profiling/server/lib/setup/steps/get_fleet_policy_step.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: inge4pres <[email protected]>
…-ref HEAD~1..HEAD --fix'
Co-authored-by: Jen Huang <[email protected]>
Signed-off-by: inge4pres <[email protected]>
inge4pres
force-pushed
the
profiling/fix-package-policy
branch
from
77f2dd2 to
7d70af9
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @inge4pres |
kibanamachine
added
v8.9.0
backport:skip
inge4pres
added
v8.8.0
v8.9.0
and removed
backport:skip
|
@kibanamachine backport 8.8 |
jbudz
added
auto-backport
inge4pres
added
the
backport:prev-minor
kibanamachine
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: inge4pres <[email protected]> ## Summary Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling. ### Checklist - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Related issues or PRs * #155642 * #150885 --------- Signed-off-by: inge4pres <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Jen Huang <[email protected]> (cherry picked from commit d4f6cf7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
) # Backport This will backport the following commits from `main` to `8.8`: - [Profiling: symbolization created on user opt-in (#156089)](#156089) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Francesco Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T18:24:54Z","message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","ci:build-cloud-image","8.8 candidate","v8.8.0","v8.9.0"],"number":156089,"url":"https://github.com/elastic/kibana/pull/156089","mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156089","number":156089,"mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <[email protected]>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Jen Huang <[email protected]>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}}]}] BACKPORT--> Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: inge4pres [email protected]
Summary
Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling.
Checklist
For maintainers
Related issues or PRs