Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Create SLO / Edit SLO Form - Custom KQL #147843

Merged

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Dec 20, 2022

Summary

This PR creates the SLO Edit Page including the components to create an SLO of type Custom KQL.

Closes #147753
Closes #148250

✅ Checklist

  • It should follow the designs
  • It should be possible to navigate to a page where a SLO creation form is displayed
  • Upon creation it should be possible to select a SLI type
  • Upon creation it should be possible to select an Index from the available indices
  • Upon creation it should be possible to create a custom KQL query for query filter, numerator and denominator
  • Upon creation it should be possible to configure a Budgeting method, time window, target.
  • Upon creation it should be possible to configure a SLO name and comment.
  • It should be possible to select an SLO to edit from the SLO List
  • When selecting an SLO to edit, it should navigate to the SLO Edit form
  • It should prefill the SLO Edit form with all existing values that are available
  • Has Storybook stories
  • Has unit tests

@CoenWarmer CoenWarmer force-pushed the feat/147753-slo-edit-form-custom-kql-new branch from 94842bc to 499b830 Compare December 20, 2022 17:19
@CoenWarmer CoenWarmer force-pushed the feat/147753-slo-edit-form-custom-kql-new branch from 53c6cfc to da8fd08 Compare December 28, 2022 09:15
@CoenWarmer CoenWarmer force-pushed the feat/147753-slo-edit-form-custom-kql-new branch from 0f23df4 to 2952620 Compare December 29, 2022 20:44
@CoenWarmer CoenWarmer force-pushed the feat/147753-slo-edit-form-custom-kql-new branch from 3b43b22 to 71805fe Compare December 30, 2022 19:27
@CoenWarmer CoenWarmer marked this pull request as ready for review December 30, 2022 19:31
@CoenWarmer CoenWarmer requested a review from a team as a code owner December 30, 2022 19:31
@CoenWarmer CoenWarmer added the release_note:feature Makes this part of the condensed release notes label Dec 30, 2022
@CoenWarmer CoenWarmer enabled auto-merge (squash) December 30, 2022 19:50
@CoenWarmer CoenWarmer changed the title [SLO] Create SLO Edit Form - Custom KQL [SLO] Create SLO / Edit SLO Form - Custom KQL Dec 30, 2022
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer CoenWarmer force-pushed the feat/147753-slo-edit-form-custom-kql-new branch from 98d9861 to 2ef861b Compare December 31, 2022 08:37
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@kdelemme
Copy link
Contributor

kdelemme commented Jan 3, 2023

I just finished testing locally, good work @CoenWarmer.
I have noted a few issues, that we should tackle in other PRs:

As soon as the tests pass, I'll merge this 🎉

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 493 504 +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 62 63 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 532.5KB 571.5KB +39.0KB
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 62 63 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit c2c9cab into elastic:main Jan 3, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Jan 3, 2023
@CoenWarmer CoenWarmer deleted the feat/147753-slo-edit-form-custom-kql-new branch January 3, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Observability Home release_note:feature Makes this part of the condensed release notes v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Implement editing an existing SLO UI [SLO] Implement creation of SLO UI for Custom KQL SLOs
5 participants