Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] [SLOEditForm] Add additional validations for Objective #148254

Closed
Tracked by #143216
CoenWarmer opened this issue Dec 31, 2022 · 1 comment · Fixed by #148419
Closed
Tracked by #143216

[SLO] [SLOEditForm] Add additional validations for Objective #148254

CoenWarmer opened this issue Dec 31, 2022 · 1 comment · Fixed by #148419
Assignees
@kdelemme
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@CoenWarmer
Copy link
Contributor 

    We need two validations for the Objective:
  • Occurrences validation which is the one currently supported
  • Timeslices validation which requires objective.timeslicesTarget and objective.timeslicesWindow.

Originally posted by @kdelemme in #147843 (comment)
@CoenWarmer CoenWarmer mentioned this issue Dec 31, 2022
Merged
12 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 31, 2022
@CoenWarmer CoenWarmer mentioned this issue Dec 31, 2022
Closed
22 tasks
@dmlemeshko dmlemeshko added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jan 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 4, 2023
@kdelemme kdelemme mentioned this issue Jan 4, 2023
Merged
@kdelemme kdelemme self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdelemme kdelemme

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(slo): slo edit form improvements kdelemme/kibana
4 participants
@CoenWarmer @kdelemme @dmlemeshko @elasticmachine