Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] [SLOEditForm] Handle edit mode #148308

Closed
Tracked by #143216
kdelemme opened this issue Jan 3, 2023 · 1 comment · Fixed by #148419
Closed
Tracked by #143216

[SLO] [SLOEditForm] Handle edit mode #148308

kdelemme opened this issue Jan 3, 2023 · 1 comment · Fixed by #148419
Assignees
@kdelemme
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Comments

@kdelemme
Copy link
Contributor

kdelemme commented Jan 3, 2023

📝 Summary

Related to #143216

Currently, when editing an existing SLO, we cannot save the changes.
There are a couple of errors:

  • The request is done on POST /slos instead of PUT /slos/:id
  • The payload includes extra parameter not allowed: id, summary, revision, createdAt, updatedAt
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0 labels Jan 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

This was referenced Jan 3, 2023
Closed
Merged
Merged
@kdelemme kdelemme self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdelemme kdelemme

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(slo): slo edit form improvements kdelemme/kibana
2 participants
@kdelemme @elasticmachine