[Security Solution] Inspect button title missing #146473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
bug
kqualters-elastic
approved these changes
Nov 28, 2022
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2022
This PR is a quick bug fix for elastic#141617 - elastic#143601 fixes the inspect title issue by passing a 'title' prop to `initializeTGridSettings`. - It appears subsequent enhancements in `sessions_viewer` also calls `initializeTGridSettings`, but in a separate manner. This PR combines the two t-grid initialization calls into one.  (cherry picked from commit 32d1dbb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2022
…6490) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution] Inspect button title missing (#146473)](#146473) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T00:36:40Z","message":"[Security Solution] Inspect button title missing (#146473)\n\nThis PR is a quick bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n- #143601 fixes the inspect title\r\nissue by passing a 'title' prop to `initializeTGridSettings`.\r\n- It appears subsequent enhancements in `sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a separate manner. This PR combines\r\nthe two t-grid initialization calls into one.\r\n\r\n\r\n","sha":"32d1dbb1f98053ac34d278d945034363695227c3","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Investigations","v8.6.0","v8.7.0"],"number":146473,"url":"https://github.com/elastic/kibana/pull/146473","mergeCommit":{"message":"[Security Solution] Inspect button title missing (#146473)\n\nThis PR is a quick bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n- #143601 fixes the inspect title\r\nissue by passing a 'title' prop to `initializeTGridSettings`.\r\n- It appears subsequent enhancements in `sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a separate manner. This PR combines\r\nthe two t-grid initialization calls into one.\r\n\r\n\r\n","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146473","number":146473,"mergeCommit":{"message":"[Security Solution] Inspect button title missing (#146473)\n\nThis PR is a quick bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n- #143601 fixes the inspect title\r\nissue by passing a 'title' prop to `initializeTGridSettings`.\r\n- It appears subsequent enhancements in `sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a separate manner. This PR combines\r\nthe two t-grid initialization calls into one.\r\n\r\n\r\n","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
","sha":"32d1dbb1f98053ac34d278d945034363695227c3","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat){kind=link}
![https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146473","number":146473,"mergeCommit":{"message":"[Security](https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146473","number":146473,"mergeCommit":{"message":"[Security){kind=link}
","sha":"32d1dbb1f98053ac34d278d945034363695227c3){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick bug fix for #141617
initializeTGridSettings.sessions_vieweralso callsinitializeTGridSettings, but in a separate manner. This PR combines the two t-grid initialization calls into one.