Skip to content

Commit

Permalink
[8.6] [Security Solution] Inspect button title missing (#146473) (#14…
Browse files Browse the repository at this point in the history
…6490)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Inspect button title missing
(#146473)](#146473)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T00:36:40Z","message":"[Security
Solution] Inspect button title missing (#146473)\n\nThis PR is a quick
bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n-
#143601 fixes the inspect
title\r\nissue by passing a 'title' prop to
`initializeTGridSettings`.\r\n- It appears subsequent enhancements in
`sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a
separate manner. This PR combines\r\nthe two t-grid initialization calls
into
one.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)","sha":"32d1dbb1f98053ac34d278d945034363695227c3","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Investigations","v8.6.0","v8.7.0"],"number":146473,"url":"https://github.com/elastic/kibana/pull/146473","mergeCommit":{"message":"[Security
Solution] Inspect button title missing (#146473)\n\nThis PR is a quick
bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n-
#143601 fixes the inspect
title\r\nissue by passing a 'title' prop to
`initializeTGridSettings`.\r\n- It appears subsequent enhancements in
`sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a
separate manner. This PR combines\r\nthe two t-grid initialization calls
into
one.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146473","number":146473,"mergeCommit":{"message":"[Security
Solution] Inspect button title missing (#146473)\n\nThis PR is a quick
bug fix for\r\nhttps://github.com//issues/141617\r\n\r\n-
#143601 fixes the inspect
title\r\nissue by passing a 'title' prop to
`initializeTGridSettings`.\r\n- It appears subsequent enhancements in
`sessions_viewer` also calls\r\n`initializeTGridSettings`, but in a
separate manner. This PR combines\r\nthe two t-grid initialization calls
into
one.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)","sha":"32d1dbb1f98053ac34d278d945034363695227c3"}}]}]
BACKPORT-->

Co-authored-by: christineweng <[email protected]>
  • Loading branch information
kibanamachine and christineweng authored Nov 29, 2022
1 parent 1752c8e commit f7d8bee
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const SessionsViewComponent: React.FC<SessionsComponentsProps> = ({
dispatch(
dataTableActions.initializeTGridSettings({
id: tableId,
title: i18n.SESSIONS_TITLE,
defaultColumns: eventsDefaultModel.columns.map((c) =>
!tGridEnabled && c.initialWidth == null
? {
Expand Down Expand Up @@ -146,15 +147,6 @@ const SessionsViewComponent: React.FC<SessionsComponentsProps> = ({
const unit = (c: number) =>
c > 1 ? i18n.TOTAL_COUNT_OF_SESSIONS : i18n.SINGLE_COUNT_OF_SESSIONS;

useEffect(() => {
dispatch(
dataTableActions.initializeTGridSettings({
id: tableId,
title: i18n.SESSIONS_TITLE,
})
);
}, [dispatch, tableId]);

return (
<div data-test-subj={TEST_ID}>
<StatefulEventsViewer
Expand Down

0 comments on commit f7d8bee

Please sign in to comment.