Skip to content

Commit

Permalink
[Security Solution] Inspect button title missing (#146473)
Browse files Browse the repository at this point in the history
This PR is a quick bug fix for
#141617

- #143601 fixes the inspect title
issue by passing a 'title' prop to `initializeTGridSettings`.
- It appears subsequent enhancements in `sessions_viewer` also calls
`initializeTGridSettings`, but in a separate manner. This PR combines
the two t-grid initialization calls into one.


![image](https://user-images.githubusercontent.com/18648970/204374253-2c98f7c7-76fd-4b60-92ae-367464e64abf.png)
  • Loading branch information
christineweng authored Nov 29, 2022
1 parent 8b0490e commit 32d1dbb
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const SessionsViewComponent: React.FC<SessionsComponentsProps> = ({
dispatch(
dataTableActions.initializeTGridSettings({
id: tableId,
title: i18n.SESSIONS_TITLE,
defaultColumns: eventsDefaultModel.columns.map((c) =>
!tGridEnabled && c.initialWidth == null
? {
Expand Down Expand Up @@ -146,15 +147,6 @@ const SessionsViewComponent: React.FC<SessionsComponentsProps> = ({
const unit = (c: number) =>
c > 1 ? i18n.TOTAL_COUNT_OF_SESSIONS : i18n.SINGLE_COUNT_OF_SESSIONS;

useEffect(() => {
dispatch(
dataTableActions.initializeTGridSettings({
id: tableId,
title: i18n.SESSIONS_TITLE,
})
);
}, [dispatch, tableId]);

return (
<div data-test-subj={TEST_ID}>
<StatefulEventsViewer
Expand Down

0 comments on commit 32d1dbb

Please sign in to comment.