[Dashboard][Lens] Add "convert to lens" action to dashboard

src/plugins/visualizations/kibana.json

@@ -18,7 +18,8 @@
     "presentationUtil",
     "dataViews",
     "dataViewEditor",
-    "unifiedSearch"
+    "unifiedSearch",
+    "usageCollection"
   ],
   "optionalPlugins": ["home", "share", "spaces", "savedObjectsTaggingOss"],
   "requiredBundles": ["kibanaUtils", "savedSearch", "kibanaReact", "charts"],

src/plugins/visualizations/public/actions/edit_in_lens_action.tsx

@@ -9,6 +9,7 @@
 import React from 'react';
 import { take } from 'rxjs/operators';
 import { EuiFlexGroup, EuiFlexItem, EuiBadge } from '@elastic/eui';
+import { METRIC_TYPE } from '@kbn/analytics';
 import { reactToUiComponent } from '@kbn/kibana-react-plugin/public';
 import { ActionExecutionContext } from '@kbn/ui-actions-plugin/public';
 import { TimefilterContract } from '@kbn/data-plugin/public';
@@ -17,7 +18,7 @@ import { IEmbeddable, ViewMode } from '@kbn/embeddable-plugin/public';
 import { Action } from '@kbn/ui-actions-plugin/public';
 import { VisualizeEmbeddable } from '../embeddable';
 import { DASHBOARD_VISUALIZATION_PANEL_TRIGGER } from '../triggers';
-import { getUiActions, getApplication, getEmbeddable } from '../services';
+import { getUiActions, getApplication, getEmbeddable, getUsageCollection } from '../services';
 
 export const ACTION_EDIT_IN_LENS = 'ACTION_EDIT_IN_LENS';
 
@@ -53,7 +54,7 @@ const isVisualizeEmbeddable = (embeddable: IEmbeddable): embeddable is Visualize
 export class EditInLensAction implements Action<EditInLensContext> {
   public id = ACTION_EDIT_IN_LENS;
   public readonly type = ACTION_EDIT_IN_LENS;
-  public order = 100;
+  public order = 49;
   public showNotification = true;
   public currentAppId: string | undefined;
 
@@ -94,6 +95,13 @@ export class EditInLensAction implements Action<EditInLensContext> {
         isEmbeddable: true,
       };
       if (navigateToLensConfig) {
+        if (this.currentAppId) {
+          getUsageCollection().reportUiCounter(
+            this.currentAppId,
+            METRIC_TYPE.CLICK,
+            ACTION_EDIT_IN_LENS
+          );
+        }
         getEmbeddable().getStateTransfer().isTransferInProgress = true;
         getUiActions().getTrigger(DASHBOARD_VISUALIZATION_PANEL_TRIGGER).exec(updatedWithMeta);
       }

src/plugins/visualizations/public/plugin.ts

@@ -42,6 +42,7 @@ import type {
   Setup as InspectorSetup,
   Start as InspectorStart,
 } from '@kbn/inspector-plugin/public';
+import type { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';
 import type { DataPublicPluginSetup, DataPublicPluginStart } from '@kbn/data-plugin/public';
 import type { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
 import type { ExpressionsSetup, ExpressionsStart } from '@kbn/expressions-plugin/public';
@@ -95,6 +96,7 @@ import {
   setExecutionContext,
   setFieldFormats,
   setSavedObjectTagging,
+  setUsageCollection,
 } from './services';
 import { VisualizeConstants } from '../common/constants';
 import { EditInLensAction } from './actions/edit_in_lens_action';
@@ -143,6 +145,7 @@ export interface VisualizationsStartDeps {
   screenshotMode: ScreenshotModePluginStart;
   fieldFormats: FieldFormatsStart;
   unifiedSearch: UnifiedSearchPublicPluginStart;
+  usageCollection: UsageCollectionStart;
 }
 
 /**
@@ -368,6 +371,7 @@ export class VisualizationsPlugin
       spaces,
       savedObjectsTaggingOss,
       fieldFormats,
+      usageCollection,
     }: VisualizationsStartDeps
   ): VisualizationsStart {
     const types = this.types.start();
@@ -387,6 +391,7 @@ export class VisualizationsPlugin
     setExecutionContext(core.executionContext);
     setChrome(core.chrome);
     setFieldFormats(fieldFormats);
+    setUsageCollection(usageCollection);
 
     if (spaces) {
       setSpaces(spaces);

src/plugins/visualizations/public/services.ts

@@ -26,6 +26,7 @@ import type { UiActionsStart } from '@kbn/ui-actions-plugin/public';
 import type { EmbeddableStart } from '@kbn/embeddable-plugin/public';
 import type { SpacesPluginStart } from '@kbn/spaces-plugin/public';
 import type { SavedObjectTaggingOssPluginStart } from '@kbn/saved-objects-tagging-oss-plugin/public';
+import type { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';
 import type { TypesStart } from './vis_types';
 
 export const [getUISettings, setUISettings] = createGetterSetter<IUiSettingsClient>('UISettings');
@@ -72,3 +73,6 @@ export const [getSpaces, setSpaces] = createGetterSetter<SpacesPluginStart>('Spa
 
 export const [getSavedObjectTagging, setSavedObjectTagging] =
   createGetterSetter<SavedObjectTaggingOssPluginStart>('SavedObjectTagging', false);
+
+export const [getUsageCollection, setUsageCollection] =
+  createGetterSetter<UsageCollectionStart>('UsageCollection');

x-pack/plugins/canvas/public/components/hooks/workpad/use_incoming_embeddable.ts

@@ -53,11 +53,20 @@ export const useIncomingEmbeddable = (selectedPage: CanvasPage) => {
           originalAst.chain[functionIndex].arguments.config[0] as string
         );
 
+        const originalType = originalAst.chain[functionIndex].arguments.type[0];
+
         // clear out resolved arg for old embeddable
         const argumentPath = [embeddableId, 'expressionRenderable'];
         dispatch(clearValue({ path: argumentPath }));
 
-        const updatedInput = { ...originalInput, ...incomingInput };
+        let updatedInput;
+
+        // if type was changed, we should not provide originalInput
+        if (originalType !== type) {
+          updatedInput = incomingInput;
+        } else {
+          updatedInput = { ...originalInput, ...incomingInput };
+        }
 
         const expression = `embeddable config="${encode(updatedInput)}"
   type="${type}"