Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Cannot Change By Reference Panel into By Value #147032

Closed
ThomThomson opened this issue Dec 5, 2022 · 1 comment · Fixed by #146363
Closed

[Canvas] Cannot Change By Reference Panel into By Value #147032

ThomThomson opened this issue Dec 5, 2022 · 1 comment · Fixed by #146363
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Kibana version: Main

Describe the bug: When converting a TSVB panel to a Lens panel, the Lens panel is by default returned by value. When the source TSVB panel is by reference, the new replacement panel fails to replace the existing by reference panel.

Steps to reproduce:

  1. Open or load a Canvas
  2. Add a by reference TSVB
  3. Edit the TSVB
  4. Click on edit in lens
  5. Click save and return.

Expected behavior:
On return, the old by reference TSVB visualization should be replaced with a new by value Lens visualization. Instead, the old TSVB visualization cannot be found.

Screenshots (if relevant):
205590965-56d54402-9ed5-43b6-b60b-7f81e18feb56
@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas labels Dec 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Dec 5, 2022
Merged
VladLasitsa added a commit that referenced this issue Dec 13, 2022
@VladLasitsa @kibanamachine @stratoula
[Dashboard][Lens] Add "convert to lens" action to dashboard (#146363)
a068b2e 
## Summary

Closes #147032
Completes part of: #144605

Added `convert to lens` action for panel in dashboards.

If legacy visualization can be converted, the notification 'dot' will
shown on context menu.
<img width="828" alt="Снимок экрана 2022-12-02 в 10 50 58"
src="https://user-images.githubusercontent.com/16915480/205253599-3f3f102e-8fdc-497c-9e81-a9e1a146687c.png">

New action looks like this:
<img width="781" alt="Снимок экрана 2022-12-02 в 10 52 42"
src="https://user-images.githubusercontent.com/16915480/205253909-79d65fd8-81d8-4cce-a61a-234d3996cf84.png">

After clicking by that action user will be navigate to lens page and see
the following, where user can replace legacy visualization to lens on
dashboard:
<img width="1347" alt="Снимок экрана 2022-12-02 в 10 53 23"
src="https://user-images.githubusercontent.com/16915480/205254013-6e26b54d-6b92-4da5-be64-01b2876ea847.png">

On save user also can replace panel on dashboard:
<img width="506" alt="Снимок экрана 2022-12-02 в 10 55 22"
src="https://user-images.githubusercontent.com/16915480/205254409-163ebf51-c075-4c9a-a070-cebc7001636d.png">

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard][Lens] Add "convert to lens" action to dashboard VladLasitsa/kibana
2 participants
@ThomThomson @elasticmachine