[Dashboard][Lens] Add "convert to lens" action to dashboard

[VladLasitsa]

Summary

Closes #147032
Completes part of: #144605

Added convert to lens action for panel in dashboards.

If legacy visualization can be converted, the notification 'dot' will shown on context menu.

New action looks like this:

After clicking by that action user will be navigate to lens page and see the following, where user can replace legacy visualization to lens on dashboard:

On save user also can replace panel on dashboard:

[elasticmachine]

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[VladLasitsa]

@elasticmachine merge upstream

[stratoula]

For click action, but maybe also the other one is also a good metric.

[VladLasitsa]

@VladLasitsa, I've looked through your proposed solution to the Canvas saved Object ID bug, and I think it will work great with one small change:

I think it needs to match the Dashboard incoming embeddable implementation, where if the type is different, we don't spread any of the originalInput at all. If you're comfortable with making that fix in the Canvas app, feel free to do so and I'll re-review. Otherwise, we can leave this as a bug for now and fix it on our side!

@ThomThomson, Put this fix in that PR.

[VladLasitsa]

• @MichaelMarcialis do we want it first or second?

@stratoula, @VladLasitsa: If possible, I'd like the convert action to appear second, after the edit action.

@MichaelMarcialis, Done

[VladLasitsa]

For click action, but maybe also the other one is also a good metric.

@stratoula, Added for click only for now

[ThomThomson]

Looked through again, and everything LGTM! One nit is that it would be nice to have a comment explaining the hidePanelTitles change when dealing with the dashboard incoming embeddable. Really cool feature!

[ThomThomson]

Thank you for adding this fix! Now we can close this issue when this PR merges.

#147032

[VladLasitsa]

@elasticmachine merge upstream

[VladLasitsa]

@elasticmachine merge upstream

[stratoula]

I am super excited about this feature 😍
LGTM, I tested it both in Canvas and Dashboard and works great! Thanx Vlad

[VladLasitsa]

@MichaelMarcialis, Could you please review again?

[VladLasitsa]

@elastic/kibana-global-experience Could you please review?

[clintandrewhall]

Our code owners changes appear minimal. LGTM!

[MichaelMarcialis]

Thanks for making those changes, @VladLasitsa! This looks great! I've added two minor comments below, but approving now under the assumption that they can be addressed.

• When converting a by-reference visualization to Lens, can the breadcrumb reference to the saved object name be contained in quotes? My previous comment to remove the quotes in the breadcrumbs was only meant to apply when converting by-value visualizations without a panel title (where we use the visualization type instead of a name, which doesn't need the quotations).

• After saving a converted visualization to the library in Lens and choosing NOT to replace the panel on dashboard, users are now given the option to "Save and return" with a checkInCircleFilled icon. Per my earlier comments, can you change the text to "Save and replace" with a save icon instead?

[VladLasitsa]

Thanks for making those changes, @VladLasitsa! This looks great! I've added two minor comments below, but approving now under the assumption that they can be addressed.

• When converting a by-reference visualization to Lens, can the breadcrumb reference to the saved object name be contained in quotes? My previous comment to remove the quotes in the breadcrumbs was only meant to apply when converting by-value visualizations without a panel title (where we use the visualization type instead of a name, which doesn't need the quotations).

• After saving a converted visualization to the library in Lens and choosing NOT to replace the panel on dashboard, users are now given the option to "Save and return" with a checkInCircleFilled icon. Per my earlier comments, can you change the text to "Save and replace" with a save icon instead?

@MichaelMarcialis thank you, Fixed these small nits

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 705101f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
lens	889	890	+1
visualizations	329	330	+1
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
visualizations	767	770	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1.0MB	1.0MB	+45.0B
dashboard	404.1KB	404.2KB	+49.0B
lens	1.3MB	1.3MB	+2.7KB
visualizations	267.4KB	267.6KB	+153.0B
total			+2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
embeddable	69.0KB	69.7KB	+736.0B
lens	29.8KB	30.5KB	+638.0B
uiActions	19.7KB	19.7KB	+91.0B
visualizations	53.8KB	56.5KB	+2.8KB
total			+4.2KB

Unknown metric groups

API count

id	before	after	diff
uiActions	133	135	+2
visualizations	797	800	+3
total			+5

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	60	66	+6
osquery	109	115	+6
securitySolution	445	451	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	69	75	+6
osquery	110	117	+7
securitySolution	521	527	+6
total			+21

History

• 💔 Build #94288 failed 1d260b1
• 💔 Build #94263 failed ed576bd
• 💚 Build #93908 succeeded 1489189
• 💚 Build #93664 succeeded 135b36d
• 💔 Build #93622 failed a5447b4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa