Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDM: Migrates kbn_server to a dev-only package #146248

Merged
merged 2 commits into from
Nov 24, 2022
Merged

IDM: Migrates kbn_server to a dev-only package #146248

merged 2 commits into from
Nov 24, 2022

Conversation

tylersmalley
Copy link
Contributor

redo of: #145785 due to failures when it hit main resulting in a revert.

fix #145193

Migrates core/server/test-helpers/kbn_server to a package
Updates imports across repo

Checklist

Delete any items that are not applicable to this PR.

@tylersmalley tylersmalley marked this pull request as ready for review November 23, 2022 23:45
@tylersmalley tylersmalley requested review from a team as code owners November 23, 2022 23:45
@tylersmalley
Copy link
Contributor Author

I will go ahead and merge this on a green CI ahead of any codeowner reviews, as they were completed on the original PR.

@tylersmalley tylersmalley added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-test-helpers-kbn-server - 46 +46

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/core-test-helpers-kbn-server - 1 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/config 8 9 +1
Unknown metric groups

API count

id before after diff
@kbn/core-test-helpers-kbn-server - 52 +52

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 5691657 into main Nov 24, 2022
@tylersmalley tylersmalley deleted the retry-145785 branch November 24, 2022 00:48
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDM: Migrate kbn_server to packages
5 participants