IDM: Migrates `kbn_server` to a dev-only package #145785

TinaHeiligers · 2022-11-19T01:12:37Z

fix #145193

Migrates core/server/test-helpers/kbn_server to a package
Updates imports across repo

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

…-fix'

…-ref HEAD~1..HEAD --fix'

elasticmachine · 2022-11-19T17:45:34Z

Pinging @elastic/kibana-core (Team:Core)

TinaHeiligers · 2022-11-19T17:48:02Z

@elasticmachine merge upstream

elasticmachine · 2022-11-19T17:48:18Z

Pinging @elastic/fleet (Team:Fleet)

TinaHeiligers · 2022-11-20T22:57:01Z

x-pack/plugins/fleet/server/integration_tests/ha_setup.test.ts

@@ -10,7 +10,12 @@ import Path from 'path';
 import { range } from 'lodash';

 import type { ISavedObjectsRepository } from '@kbn/core/server';
-import * as kbnTestServer from '@kbn/core/test_helpers/kbn_server';
+import type { TestElasticsearchUtils, createRoot } from '@kbn/core-test-helpers-kbn-server';


@elastic/fleet I split the imports out into separate methods and/or types after migrating the kbn_server utilities to a package.

TinaHeiligers · 2022-11-20T22:58:10Z

x-pack/plugins/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts

@@ -8,10 +8,11 @@
 import Boom from '@hapi/boom';

 // @ts-ignore
+import type { createRoot } from '@kbn/core-test-helpers-kbn-server';


@elastic/kibana-security I split the imports out into separate methods and/or types after migrating the kbn_server utilities to a package.

You could technically also have done this to the same effect:

import { type createRoot, request as kbnTestServerRequest } from '@kbn/core-test-helpers-kbn-server';

watson · 2022-11-21T09:14:31Z

x-pack/plugins/spaces/server/lib/request_interceptors/on_request_interceptor.test.ts

+import type { createRoot } from '@kbn/core-test-helpers-kbn-server';
+import { request } from '@kbn/core-test-helpers-kbn-server';


Same thing here if you like:

Suggested change

import type { createRoot } from '@kbn/core-test-helpers-kbn-server';

import { request } from '@kbn/core-test-helpers-kbn-server';

import { type createRoot, request } from '@kbn/core-test-helpers-kbn-server';

watson

Kibana Platform Security changes LGTM 👍

I added a few comments about how to combine the imports into one, but it's not important

nchaulet

Fleet changes 🚀

TinaHeiligers · 2022-11-21T21:18:58Z

@elasticmachine merge upstream

rshen91

Changes LGTM! thanks for migrating!

TinaHeiligers · 2022-11-22T20:39:18Z

@elasticmachine merge upstream

pgayvallet

LGTM

pgayvallet · 2022-11-23T13:16:32Z

src/core/server/integration_tests/saved_objects/migrations/actions/actions.test.ts

+import type { TestElasticsearchUtils } from '@kbn/core-test-helpers-kbn-server';
+import { createTestServers } from '@kbn/core-test-helpers-kbn-server';


NIT: (multiple occurrences)

import { createTestServers, type TestElasticsearchUtils } from '@kbn/core-test-helpers-kbn-server';

…-ref HEAD~1..HEAD --fix'

…-fix'

kibana-ci · 2022-11-23T21:15:38Z

💚 Build Succeeded

Buildkite Build
Commit: 6843f32

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/core-test-helpers-kbn-server`	-	46	+46

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`@kbn/core-test-helpers-kbn-server`	-	1	+1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/config`	8	9	+1

Unknown metric groups

API count

id	before	after	diff
`@kbn/core-test-helpers-kbn-server`	-	52	+52

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	109	115	+6
`securitySolution`	443	449	+6
total			+20

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	68	74	+6
`osquery`	110	117	+7
`securitySolution`	520	526	+6
total			+21

History

💚 Build #90146 succeeded f46d0ff
💔 Build #90138 failed e85e5f4
💔 Build #89845 failed 297f8e5
💚 Build #89471 succeeded 9941af9
💚 Build #89469 succeeded ee85ccb
💔 Build #89452 failed 9d9b102

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This reverts commit 25c6535.

tylersmalley · 2022-11-23T22:39:44Z

Sorry @TinaHeiligers, I had to revert this - there were multiple failures due to incompatible merges

CI job on main: https://buildkite.com/elastic/kibana-on-merge/builds/24078#0184a659-17eb-4c09-ad88-440364ca64eb

main: 8e55ec5

…5785)"" This reverts commit 8e55ec5.

redo of: #145785 due to failures when it hit main resulting in a revert. fix #145193 Migrates `core/server/test-helpers/kbn_server` to a package Updates imports across repo ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Christiane (Tina) Heiligers <[email protected]>

TinaHeiligers added 4 commits November 18, 2022 16:19

Creates package core-test-helpers-kbn-server as dev only

00a196c

Updates imports in core integration tests

6f364df

Updates remaining imports of kbnTestServer

3dc87cb

Removes kbn_server from core

387ebb5

TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.7.0 labels Nov 19, 2022

TinaHeiligers added 4 commits November 18, 2022 18:19

Updates README

39294b1

small code change fixes

dd8e14e

Cleans up bazel config

5c4100b

updates import

0ea735c

TinaHeiligers force-pushed the kbn-145193-core-kbn_server-as-package branch from 13eb625 to 0ea735c Compare November 19, 2022 02:03

kibanamachine and others added 4 commits November 19, 2022 02:09

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

8b57ed9

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

9d9b102

…-fix'

Removes lost dir to path

66cb0e7

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

ee85ccb

…-ref HEAD~1..HEAD --fix'

TinaHeiligers marked this pull request as ready for review November 19, 2022 17:45

TinaHeiligers requested review from a team as code owners November 19, 2022 17:45

Merge branch 'main' into kbn-145193-core-kbn_server-as-package

9941af9

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 19, 2022

TinaHeiligers commented Nov 20, 2022

View reviewed changes

watson reviewed Nov 21, 2022

View reviewed changes

watson approved these changes Nov 21, 2022

View reviewed changes

nchaulet approved these changes Nov 21, 2022

View reviewed changes

Merge branch 'main' into kbn-145193-core-kbn_server-as-package

297f8e5

rshen91 approved these changes Nov 22, 2022

View reviewed changes

kibanamachine and others added 3 commits November 22, 2022 15:39

Merge branch 'main' into kbn-145193-core-kbn_server-as-package

e85e5f4

Updates import path in new integration test

90f6fae

Condensed imports in fleet

f46d0ff

pgayvallet approved these changes Nov 23, 2022

View reviewed changes

TinaHeiligers added 3 commits November 23, 2022 09:33

combined import of types and methods

4b0fb1b

Condenses some more imports

baccdda

Condenses some more imports

785c074

TinaHeiligers enabled auto-merge (squash) November 23, 2022 19:49

kibanamachine added 2 commits November 23, 2022 19:54

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

dcbf682

…-ref HEAD~1..HEAD --fix'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6843f32

…-fix'

TinaHeiligers merged commit 25c6535 into elastic:main Nov 23, 2022

tylersmalley added a commit that referenced this pull request Nov 23, 2022

Revert "IDM: Migrates kbn_server to a dev-only package (#145785)"

990bdac

This reverts commit 25c6535.

tylersmalley pushed a commit that referenced this pull request Nov 23, 2022

Revert "IDM: Migrates kbn_server to a dev-only package (#145785)"

8e55ec5

This reverts commit 25c6535.

TinaHeiligers mentioned this pull request Nov 23, 2022

Revert revert of kbn-145785 with fix #146247

Closed

tylersmalley pushed a commit that referenced this pull request Nov 23, 2022

Revert "Revert "IDM: Migrates kbn_server to a dev-only package (#14…

389139e

…5785)"" This reverts commit 8e55ec5.

tylersmalley mentioned this pull request Nov 23, 2022

IDM: Migrates kbn_server to a dev-only package #146248

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IDM: Migrates `kbn_server` to a dev-only package #145785

IDM: Migrates `kbn_server` to a dev-only package #145785

TinaHeiligers commented Nov 19, 2022

elasticmachine commented Nov 19, 2022

TinaHeiligers commented Nov 19, 2022

elasticmachine commented Nov 19, 2022

TinaHeiligers Nov 20, 2022 •

edited

Loading

TinaHeiligers Nov 20, 2022

watson Nov 21, 2022

TinaHeiligers Nov 22, 2022

watson Nov 21, 2022

watson left a comment

nchaulet left a comment

TinaHeiligers commented Nov 21, 2022

rshen91 left a comment

TinaHeiligers commented Nov 22, 2022

pgayvallet left a comment

pgayvallet Nov 23, 2022

kibana-ci commented Nov 23, 2022

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

tylersmalley commented Nov 23, 2022

		import type { createRoot } from '@kbn/core-test-helpers-kbn-server';
		import { request } from '@kbn/core-test-helpers-kbn-server';

	import type { createRoot } from '@kbn/core-test-helpers-kbn-server';
	import { request } from '@kbn/core-test-helpers-kbn-server';
	import { type createRoot, request } from '@kbn/core-test-helpers-kbn-server';

		import type { TestElasticsearchUtils } from '@kbn/core-test-helpers-kbn-server';
		import { createTestServers } from '@kbn/core-test-helpers-kbn-server';

IDM: Migrates kbn_server to a dev-only package #145785

IDM: Migrates kbn_server to a dev-only package #145785

Conversation

TinaHeiligers commented Nov 19, 2022

Checklist

elasticmachine commented Nov 19, 2022

TinaHeiligers commented Nov 19, 2022

elasticmachine commented Nov 19, 2022

TinaHeiligers Nov 20, 2022 • edited Loading

Choose a reason for hiding this comment

TinaHeiligers Nov 20, 2022

Choose a reason for hiding this comment

watson Nov 21, 2022

Choose a reason for hiding this comment

TinaHeiligers Nov 22, 2022

Choose a reason for hiding this comment

watson Nov 21, 2022

Choose a reason for hiding this comment

watson left a comment

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

TinaHeiligers commented Nov 21, 2022

rshen91 left a comment

Choose a reason for hiding this comment

TinaHeiligers commented Nov 22, 2022

pgayvallet left a comment

Choose a reason for hiding this comment

pgayvallet Nov 23, 2022

Choose a reason for hiding this comment

kibana-ci commented Nov 23, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Any counts in public APIs

Public APIs missing exports

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

tylersmalley commented Nov 23, 2022

IDM: Migrates `kbn_server` to a dev-only package #145785

IDM: Migrates `kbn_server` to a dev-only package #145785

TinaHeiligers Nov 20, 2022 •

edited

Loading