Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDM: Migrate kbn_server to packages #145193

Closed
TinaHeiligers opened this issue Nov 14, 2022 · 2 comments · Fixed by #145785 or #146248
Closed

IDM: Migrate kbn_server to packages #145193

TinaHeiligers opened this issue Nov 14, 2022 · 2 comments · Fixed by #145785 or #146248
Assignees
@TinaHeiligers
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Nov 14, 2022 •
edited
Loading

Part of #134112
Packages cannot depend on code in src. ATM, a few core integration tests depend on kbnTestServer imported from src/core/test_helpers. These helpers also need to migrate to packages/a package.

blocks #145063
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 14, 2022
@TinaHeiligers TinaHeiligers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 14, 2022
@TinaHeiligers TinaHeiligers mentioned this issue Nov 16, 2022
Closed
@TinaHeiligers TinaHeiligers self-assigned this Nov 18, 2022
@TinaHeiligers TinaHeiligers mentioned this issue Nov 19, 2022
Merged
1 task
TinaHeiligers added a commit that referenced this issue Nov 23, 2022
@TinaHeiligers
IDM: Migrates kbn_server to a dev-only package (#145785)
25c6535 
Co-authored-by: kibanamachine <[email protected]>
fix #145193
@TinaHeiligers TinaHeiligers reopened this Nov 23, 2022
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley tylersmalley mentioned this issue Nov 23, 2022
Merged
1 task
tylersmalley pushed a commit that referenced this issue Nov 24, 2022
@TinaHeiligers
IDM: Migrates kbn_server to a dev-only package (#146248)
5691657 
redo of: #145785 due to failures
when it hit main resulting in a revert.

fix #145193

Migrates `core/server/test-helpers/kbn_server` to a package
Updates imports across repo

### Checklist

Delete any items that are not applicable to this PR.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
2 participants
@TinaHeiligers @elasticmachine