Fix index templates date validation 143412 #145318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tests were already skipped.
…n accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped.
…ssage no longer exists for this component.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
cuff-links
added
v8.5.2
v8.6.0
Feature:Index Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
cuff-links
added
release_note:skip
yuliacech
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Thanks a lot for fixing this, @cuff-links!
Code changes LGTM, didn't test locally.
kibanamachine
pushed a commit
that referenced
this pull request
Nov 17, 2022
Closes #94168 ## Summary I took a look at the code and noticed that the only validation rule was not allowing spaces so I removed that code and tested it. The validation code wasn't performing any other validations so I removed that. Co-authored-by: cuffs <[email protected]> (cherry picked from commit 67af5c4)
kibanamachine
pushed a commit
that referenced
this pull request
Nov 17, 2022
Closes #94168 ## Summary I took a look at the code and noticed that the only validation rule was not allowing spaces so I removed that code and tested it. The validation code wasn't performing any other validations so I removed that. Co-authored-by: cuffs <[email protected]> (cherry picked from commit 67af5c4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [Fix index templates date validation 143412 (#145318)](#145318) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"John Dorlus","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T17:15:44Z","message":"Fix index templates date validation 143412 (#145318)\n\nCloses https://github.com/elastic/kibana/issues/94168\r\n\r\n## Summary\r\n\r\nI took a look at the code and noticed that the only validation rule was\r\nnot allowing spaces so I removed that code and tested it. The validation\r\ncode wasn't performing any other validations so I removed that.\r\n\r\nCo-authored-by: cuffs <[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Deployment Management","release_note:skip","auto-backport","v8.6.0","v8.5.2"],"number":145318,"url":"https://github.com/elastic/kibana/pull/145318","mergeCommit":{"message":"Fix index templates date validation 143412 (#145318)\n\nCloses https://github.com/elastic/kibana/issues/94168\r\n\r\n## Summary\r\n\r\nI took a look at the code and noticed that the only validation rule was\r\nnot allowing spaces so I removed that code and tested it. The validation\r\ncode wasn't performing any other validations so I removed that.\r\n\r\nCo-authored-by: cuffs <[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: John Dorlus <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
# Backport This will backport the following commits from `main` to `8.5`: - [Fix index templates date validation 143412 (#145318)](#145318) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"John Dorlus","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T17:15:44Z","message":"Fix index templates date validation 143412 (#145318)\n\nCloses https://github.com/elastic/kibana/issues/94168\r\n\r\n## Summary\r\n\r\nI took a look at the code and noticed that the only validation rule was\r\nnot allowing spaces so I removed that code and tested it. The validation\r\ncode wasn't performing any other validations so I removed that.\r\n\r\nCo-authored-by: cuffs <[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Deployment Management","release_note:skip","auto-backport","v8.6.0","v8.5.2"],"number":145318,"url":"https://github.com/elastic/kibana/pull/145318","mergeCommit":{"message":"Fix index templates date validation 143412 (#145318)\n\nCloses https://github.com/elastic/kibana/issues/94168\r\n\r\n## Summary\r\n\r\nI took a look at the code and noticed that the only validation rule was\r\nnot allowing spaces so I removed that code and tested it. The validation\r\ncode wasn't performing any other validations so I removed that.\r\n\r\nCo-authored-by: cuffs <[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: John Dorlus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94168
Summary
I took a look at the code and noticed that the only validation rule was not allowing spaces so I removed that code and tested it. The validation code wasn't performing any other validations so I removed that.