Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index templates date validation 143412 #145318

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
1605104
Removed comment of the issue that was referenced for the skip. But th…
cuff-links Sep 8, 2022
f74b2cc
Merge branch 'main' of github.com:elastic/kibana into main
cuff-links Sep 12, 2022
2417dec
Merge branch 'main' of github.com:elastic/kibana into main
cuff-links Sep 13, 2022
dcc34ae
Merge branch 'main' of github.com:elastic/kibana
Sep 14, 2022
965b476
Merge branch 'main' of github.com:elastic/kibana
cuff-links Sep 14, 2022
6a7bcff
Merge branch 'main' of github.com:elastic/kibana
Sep 15, 2022
9f4d356
Merge branch 'main' of github.com:cuff-links/kibana
Sep 15, 2022
77ac6f6
Merge branch 'main' of github.com:elastic/kibana
Sep 20, 2022
c32deee
Merge branch 'main' of github.com:elastic/kibana
cuff-links Sep 21, 2022
9d29832
Merge branch 'main' of github.com:elastic/kibana
Sep 21, 2022
b81531c
Merge branch 'main' of github.com:cuff-links/kibana
Sep 21, 2022
86b5eb3
Merge branch 'main' of github.com:elastic/kibana
cuff-links Sep 26, 2022
dd1f520
Merge branch 'main' of github.com:cuff-links/kibana
cuff-links Sep 26, 2022
7da9187
Merge branch 'main' of github.com:elastic/kibana
Sep 26, 2022
1f743d0
Merge branch 'main' of github.com:cuff-links/kibana
Sep 26, 2022
38680df
Merge branch 'main' of github.com:elastic/kibana
Sep 27, 2022
1cfb1d1
Merge branch 'main' of github.com:elastic/kibana
cuff-links Sep 28, 2022
fd1727b
Added a describe block for the tests that involve space b. There is a…
Oct 28, 2022
e3ec114
Merge branch 'main' of github.com:elastic/kibana
Oct 28, 2022
05c739c
Merge branch 'main' of github.com:cuff-links/kibana
cuff-links Oct 30, 2022
8d12337
Merge branch 'main' of github.com:elastic/kibana
Nov 1, 2022
77ef5e8
Merge branch 'main' of github.com:elastic/kibana
cuff-links Nov 1, 2022
12b08b7
Added CCS Test for integration test.
cuff-links Nov 2, 2022
08a2558
Merge branch 'main' of github.com:elastic/kibana
Nov 3, 2022
097602c
Merge branch 'main' of github.com:cuff-links/kibana
cuff-links Nov 3, 2022
6fb3f0b
Merge branch 'main' of github.com:elastic/kibana
cuff-links Nov 3, 2022
9ec2801
Merge branch 'main' of github.com:elastic/kibana
Nov 4, 2022
2060a72
Merge branch 'main' of github.com:cuff-links/kibana
Nov 4, 2022
20959cb
Merge branch 'main' of github.com:elastic/kibana
Nov 8, 2022
c3024e2
Merge branch 'main' of github.com:elastic/kibana
Nov 10, 2022
c37d730
Merge branch 'main' of github.com:elastic/kibana
Nov 15, 2022
ff3e5c6
Merge branch 'main' of github.com:elastic/kibana
cuff-links Nov 15, 2022
9428b4b
Merge branch 'main' of github.com:cuff-links/kibana
cuff-links Nov 15, 2022
be3a5c0
Removed validation rule that did not allow spaces.
Nov 16, 2022
785c131
Removed unused variables.
Nov 16, 2022
111e9bd
Removed validation error message translations since the validation me…
Nov 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import { FormattedMessage } from '@kbn/i18n-react';
import { EuiLink, EuiCode } from '@elastic/eui';

import { documentationService } from '../../../../services/documentation';
import { FormSchema, FIELD_TYPES, VALIDATION_TYPES, fieldValidators } from '../../shared_imports';
import { FormSchema, FIELD_TYPES, fieldValidators } from '../../shared_imports';
import { ComboBoxOption } from '../../types';

const { containsCharsField, isJsonField } = fieldValidators;
const { isJsonField } = fieldValidators;

const fieldPathComboBoxConfig = {
helpText: i18n.translate(
Expand Down Expand Up @@ -168,20 +168,6 @@ export const configurationFormSchema: FormSchema = {
),
type: FIELD_TYPES.COMBO_BOX,
defaultValue: ['strict_date_optional_time', 'yyyy/MM/dd HH:mm:ss Z||yyyy/MM/dd Z'],
validations: [
{
validator: containsCharsField({
message: i18n.translate(
'xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage',
{
defaultMessage: 'Spaces are not allowed.',
}
),
chars: ' ',
}),
type: VALIDATION_TYPES.ARRAY_ITEM,
},
],
},
},
_routing: {
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -14401,7 +14401,6 @@
"xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "Mapper les chaînes de dates en tant que dates",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "En savoir plus.",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "Formats de dates",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "Les espaces ne sont pas autorisés.",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "Par défaut, les champs non mappés sont ignorés silencieusement lorsque le mapping dynamique est désactivé. Vous pouvez aussi choisir de lever une exception lorsqu'un document contient un champ non mappé.",
"xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "Activer le mapping dynamique",
"xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "Exclure les champs",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -14387,7 +14387,6 @@
"xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "日付文字列の日付としてのマッピング",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "詳細情報",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "日付フォーマット",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "スペースは使用できません。",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "デフォルトとしては、動的マッピングが無効の場合、マップされていないフィールドは通知なし無視されます。オプションとして、ドキュメントがマッピングされていないフィールドを含む場合、例外を選択とすることも可能です。",
"xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "動的マッピングの有効化",
"xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "フィールドの除外",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -14407,7 +14407,6 @@
"xpack.idxMgmt.mappingsEditor.configuration.dateDetectionFieldLabel": "将日期字符串映射为日期",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldDocumentionLink": "了解详情。",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldLabel": "日期格式",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicDatesFieldValidationErrorMessage": "不允许使用空格。",
"xpack.idxMgmt.mappingsEditor.configuration.dynamicMappingStrictHelpText": "默认情况下,禁用动态映射时,将会忽略未映射字段。文档包含未映射字段时,您可以根据需要引发异常。",
"xpack.idxMgmt.mappingsEditor.configuration.enableDynamicMappingsLabel": "启用动态映射",
"xpack.idxMgmt.mappingsEditor.configuration.excludeSourceFieldsLabel": "排除字段",
Expand Down