Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index Management doesn't allow spaces in date formats #94168

Closed
n0othing opened this issue Mar 9, 2021 · 3 comments · Fixed by #145318
Closed

Index Management doesn't allow spaces in date formats #94168

n0othing opened this issue Mar 9, 2021 · 3 comments · Fixed by #145318
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@n0othing
Copy link
Member

n0othing commented Mar 9, 2021

Kibana version: 7.11.1

Describe the bug:

Index Management > Create legacy template feature doesn't allow spaces in dynamic date formats. Wrapping the pattern in quotes has not effect.

Steps to reproduce:

  1. Navigate to Index Management > Create legacy template
  2. In the Mappings section click Advanced options and try to add MM/dd/yyyy HH:mm:ss as a date pattern.

Expected behavior:

Spaces should be allowed because they're valid if submitted against Elasticsearch's API [1].

Screenshots (if relevant):

index_management

[1] https://www.elastic.co/guide/en/elasticsearch/reference/current/date.html#multiple-date-formats
@n0othing n0othing added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI labels Mar 9, 2021
@sebelga sebelga added the good first issue low hanging fruit label Apr 26, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 26, 2021
@sebelga sebelga added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Apr 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 26, 2021
@scottdfedorov
Copy link

scottdfedorov commented Sep 13, 2021 •
edited
Loading

Hate to be a bother, but any update on this issue? We still cannot add a date format like yyyy-MM-dd HH:mm:ss via Kibana... :(

@gbanasiak
Copy link
Contributor

This is still the case in 8.3.2.

@cuff-links cuff-links mentioned this issue Nov 16, 2022
Merged
cuff-links pushed a commit that referenced this issue Nov 17, 2022
Fix index templates date validation 143412 (#145318)
67af5c4 
Closes #94168

## Summary

I took a look at the code and noticed that the only validation rule was
not allowing spaces so I removed that code and tested it. The validation
code wasn't performing any other validations so I removed that.

Co-authored-by: cuffs <[email protected]>
kibanamachine pushed a commit that referenced this issue Nov 17, 2022
Fix index templates date validation 143412 (#145318)
b3ee7f1 
Closes #94168

## Summary

I took a look at the code and noticed that the only validation rule was
not allowing spaces so I removed that code and tested it. The validation
code wasn't performing any other validations so I removed that.

Co-authored-by: cuffs <[email protected]>
(cherry picked from commit 67af5c4)
kibanamachine pushed a commit that referenced this issue Nov 17, 2022
Fix index templates date validation 143412 (#145318)
842a538 
Closes #94168

## Summary

I took a look at the code and noticed that the only validation rule was
not allowing spaces so I removed that code and tested it. The validation
code wasn't performing any other validations so I removed that.

Co-authored-by: cuffs <[email protected]>
(cherry picked from commit 67af5c4)
kibanamachine referenced this issue Nov 17, 2022
@kibanamachine
[8.6] Fix index templates date validation 143412 (#145318) (#145602)
f2a3956 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Fix index templates date validation 143412
(#145318)](#145318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"John
Dorlus","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T17:15:44Z","message":"Fix
index templates date validation 143412 (#145318)\n\nCloses
https://github.com/elastic/kibana/issues/94168\r\n\r\n##
Summary\r\n\r\nI took a look at the code and noticed that the only
validation rule was\r\nnot allowing spaces so I removed that code and
tested it. The validation\r\ncode wasn't performing any other
validations so I removed that.\r\n\r\nCo-authored-by: cuffs
<[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Deployment
Management","release_note:skip","auto-backport","v8.6.0","v8.5.2"],"number":145318,"url":"https://github.com/elastic/kibana/pull/145318","mergeCommit":{"message":"Fix
index templates date validation 143412 (#145318)\n\nCloses
https://github.com/elastic/kibana/issues/94168\r\n\r\n##
Summary\r\n\r\nI took a look at the code and noticed that the only
validation rule was\r\nnot allowing spaces so I removed that code and
tested it. The validation\r\ncode wasn't performing any other
validations so I removed that.\r\n\r\nCo-authored-by: cuffs
<[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: John Dorlus <[email protected]>
kibanamachine referenced this issue Nov 17, 2022
@kibanamachine
[8.5] Fix index templates date validation 143412 (#145318) (#145603)
0dc0a77 
# Backport

This will backport the following commits from `main` to `8.5`:
- [Fix index templates date validation 143412
(#145318)](#145318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"John
Dorlus","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T17:15:44Z","message":"Fix
index templates date validation 143412 (#145318)\n\nCloses
https://github.com/elastic/kibana/issues/94168\r\n\r\n##
Summary\r\n\r\nI took a look at the code and noticed that the only
validation rule was\r\nnot allowing spaces so I removed that code and
tested it. The validation\r\ncode wasn't performing any other
validations so I removed that.\r\n\r\nCo-authored-by: cuffs
<[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Deployment
Management","release_note:skip","auto-backport","v8.6.0","v8.5.2"],"number":145318,"url":"https://github.com/elastic/kibana/pull/145318","mergeCommit":{"message":"Fix
index templates date validation 143412 (#145318)\n\nCloses
https://github.com/elastic/kibana/issues/94168\r\n\r\n##
Summary\r\n\r\nI took a look at the code and noticed that the only
validation rule was\r\nnot allowing spaces so I removed that code and
tested it. The validation\r\ncode wasn't performing any other
validations so I removed that.\r\n\r\nCo-authored-by: cuffs
<[email protected]>","sha":"67af5c4c6b788a0e03aa6c483e5dcba052628fcc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: John Dorlus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix index templates date validation 143412 cuff-links/kibana
5 participants
@sebelga @n0othing @gbanasiak @elasticmachine @scottdfedorov