Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating axe-core to latest #144940

Merged
merged 39 commits into from
Mar 28, 2023
Merged

Updating axe-core to latest #144940

merged 39 commits into from
Mar 28, 2023

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Nov 9, 2022 •
edited by kibanamachine
Loading

Updated axe-core to latest 4.5.1 4.6.1

Bugs logged:

  1. Ensures interactive controls are not nested on discover data grid for sort and setting row height panel #148567
  2. Console has a11y has validation error on interactive Ensures interactive controls  #148538
  3. Filter panel a11y violations #148570
  4. Ensures every ARIA button, link and menuitem has an accessible name validation error in demo flights chart #148647
  5. Dashboard controls a11y tests Filter by type panel element click interrupted error  #148657
  6. Uptime Accessibility detail page a11y violation error  #148659
  7. a11y bugs on the new filter panel #150368
  8. [ML] "Buttons must have discernible text" a11y violation on the memory usage annotation marker #153596
  9. [ML] [aria-allowed-attr]: Ensures ARIA attributes are allowed for an element's role on ML notifications button  #153592
  10. Ensures select element has an accessible name a11y rule violation on create follow index form #153599
  11. Ensures ARIA attributes are allowed for an element's role rule violation on uptime Accessibility detail page #153601
  12. A11y issues on create policy form on snapshot and restore page #153788

Meta for tracking interactive controls:
(Accessibility)(Meta) Track nested-interactive axe-core violations in product UI so we can re-enable the rule #152494

Please note right now the check is disabled.

@bhavyarm bhavyarm self-assigned this Nov 9, 2022
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Nov 9, 2022

@1Copenut can you please take a look at the errors here and let me know if they are legit? Thanks!

@bhavyarm bhavyarm requested a review from 1Copenut January 9, 2023 17:27
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jan 9, 2023

Logged. Lets see if we get a clean run now.

  1. Ensures interactive controls are not nested on discover data grid for sort and setting row height panel #148567
  2. Console has a11y has validation error on interactive Ensures interactive controls  #148538
  3. Filter panel a11y violations #148570

@bhavyarm bhavyarm marked this pull request as ready for review January 9, 2023 17:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm added enhancement New value added to drive a business result release_note:enhancement labels Jan 9, 2023
@bhavyarm bhavyarm marked this pull request as draft January 9, 2023 17:31
This was referenced Jan 10, 2023
Closed
Open
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jan 10, 2023 •
edited
Loading

Logged:

  1. Ensures every ARIA button, link and menuitem has an accessible name validation error in demo flights chart #148647
  2. Dashboard controls a11y tests Filter by type panel element click interrupted error  #148657
  3. Uptime Accessibility detail page a11y violation error  #148659

@bhavyarm bhavyarm force-pushed the updateAxeCoreVersion branch from 2b7cd95 to 2018008 Compare January 23, 2023 06:03
@bhavyarm
Copy link
Contributor Author

Uptime issue - #153601

@bhavyarm
Copy link
Contributor Author

a11y issue for snapshot and restore a11y test failures - #153788

@bhavyarm bhavyarm marked this pull request as ready for review March 27, 2023 20:07
@bhavyarm bhavyarm requested a review from a team as a code owner March 27, 2023 20:07
@bhavyarm bhavyarm force-pushed the updateAxeCoreVersion branch from 1d06488 to 1f35417 Compare March 27, 2023 20:49
@bhavyarm
Copy link
Contributor Author

Flaky tests runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2046

marius-dr
marius-dr approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1Copenut
1Copenut approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

packages/kbn-axe-config/index.ts
Comment on lines +57 to +59
'nested-interactive': {
enabled: false, // tracker here - https://github.com/elastic/kibana/issues/152494 disabled because we have too many failures on interactive controls
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhavya and I discussed ignoring this rule. It's not ideal but the right call in the name of getting access to the updated rule set.

@bhavyarm bhavyarm force-pushed the updateAxeCoreVersion branch from eb585fd to 00c1b68 Compare March 27, 2023 21:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/axe-config 10 12 +2
Unknown metric groups

API count

id before after diff
@kbn/axe-config 10 12 +2

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit 23b7137 into elastic:main Mar 28, 2023
@kibanamachine kibanamachine mentioned this pull request Mar 28, 2023
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 28, 2023
@bhavyarm
Updating axe-core to latest (elastic#144940)
92bd68e 
(cherry picked from commit 23b7137)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.6 Backport failed because of merge conflicts
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 144940

Questions ?

Please refer to the Backport tool documentation

@peteharverson peteharverson mentioned this pull request Jun 15, 2023
Merged
7 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 144940 locally

@bhavyarm bhavyarm added the backport:skip This commit does not require backporting label Jan 15, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

@1Copenut 1Copenut 1Copenut approved these changes

Assignees

@bhavyarm bhavyarm

Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Project:Accessibility release_note:enhancement Team:QA Team label for QA Team v8.6.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhavyarm @elasticmachine @1Copenut @kibana-ci @kibanamachine @marius-dr