Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y bugs on the new filter panel #150368

Closed
bhavyarm opened this issue Feb 6, 2023 · 4 comments · Fixed by #150411
Closed

a11y bugs on the new filter panel #150368

bhavyarm opened this issue Feb 6, 2023 · 4 comments · Fixed by #150411
Assignees
@stratoula
Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Feb 6, 2023

Kibana version: 8.7.0 snapshot

Browser version: chrome latest

Describe the bug: The new filter panel has 3 critical and serious a11y issues.

  1. Form elements must have labels

Screen Shot 2023-02-06 at 11 12 38 PM

  1. Form elements must have labels

Screen Shot 2023-02-06 at 11 12 41 PM

  1. Elements must use only allowed aria-attribute

Screen Shot 2023-02-06 at 11 29 16 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Feb 6, 2023

cc @stratoula

@bhavyarm bhavyarm mentioned this issue Feb 6, 2023
Merged
@stratoula stratoula added Project:Accessibility enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Feb 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@stratoula stratoula added Feature:Unified search Unified search related tasks and removed Feature:Filters labels Feb 7, 2023
@stratoula stratoula mentioned this issue Feb 7, 2023
Merged
@stratoula stratoula self-assigned this Feb 7, 2023
stratoula added a commit that referenced this issue Feb 8, 2023
@stratoula
[Unified search] Fixes ally issues (#150411)
c3bab3e 
## Summary

Closes #150368

Fixes ally issues on Unified search introduced by the new UI.
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 1, 2023

@stratoula this came up during a11y fed meeting and we would like to treat them as bugs. So changing the label here. Thanks!

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Unified search] Fixes ally issues stratoula/kibana
3 participants
@bhavyarm @elasticmachine @stratoula