Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y issues on create policy form on snapshot and restore page #153788

Closed
bhavyarm opened this issue Mar 27, 2023 · 1 comment · Fixed by #169635
Closed

A11y issues on create policy form on snapshot and restore page #153788

bhavyarm opened this issue Mar 27, 2023 · 1 comment · Fixed by #169635
Assignees
@ElenaStoeva
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@bhavyarm
Copy link
Contributor

Kibana version: main

Browser version: chrome latest

Describe the bug: There are two a11y issues on create policy form(snapshot retention form) on snapshot and restore page

  1. Form elements must have labels on Delete after input box for period

Screen Shot 2023-03-27 at 11 32 28 AM

  1. Select elements must have accessible names on delete after combo box for setting periods.

Screen Shot 2023-03-27 at 11 30 54 AM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Mar 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@bhavyarm bhavyarm mentioned this issue Mar 27, 2023
Merged
@1Copenut 1Copenut mentioned this issue Mar 27, 2023
Open
77 tasks
@bhavyarm bhavyarm mentioned this issue Mar 29, 2023
Closed
@ElenaStoeva ElenaStoeva self-assigned this Oct 24, 2023
@ElenaStoeva ElenaStoeva mentioned this issue Oct 24, 2023
Merged
ElenaStoeva added a commit that referenced this issue Oct 27, 2023
@ElenaStoeva
[Snapshot Restore] Fix a11y issue in policy form (#169635)
7ef118c 
Fixes #153788

## Summary

This PR fixes the a11y issue in the "Create policy" form for the two
"Expiration" fields.

**Before:**
<img width="1674" alt="Screenshot 2023-10-24 at 12 06 03"
src="https://github.com/elastic/kibana/assets/59341489/8ac5d406-8b84-418c-a327-7edf2d8dac3d">



**After:**
<img width="1674" alt="Screenshot 2023-10-24 at 12 06 35"
src="https://github.com/elastic/kibana/assets/59341489/e09689c6-8d0c-43a9-9e97-b63cca2d060d">



The aria-labels can also be tested with a screen reader (e.g. VoiceOver
on Mac).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snapshot Restore] Fix a11y issue in policy form ElenaStoeva/kibana
3 participants
@bhavyarm @elasticmachine @ElenaStoeva