Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshot Restore] Fix a11y issue in policy form #169635

Merged
merged 4 commits into from
Oct 27, 2023
Merged

[Snapshot Restore] Fix a11y issue in policy form #169635

merged 4 commits into from
Oct 27, 2023

Conversation

ElenaStoeva
Copy link
Contributor

Fixes #153788

Summary

This PR fixes the a11y issue in the "Create policy" form for the two "Expiration" fields.

Before:
Screenshot 2023-10-24 at 12 06 03

After:
Screenshot 2023-10-24 at 12 06 35

The aria-labels can also be tested with a screen reader (e.g. VoiceOver on Mac).

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Oct 24, 2023
@ElenaStoeva ElenaStoeva self-assigned this Oct 24, 2023
@ElenaStoeva ElenaStoeva marked this pull request as ready for review October 24, 2023 11:13
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 24, 2023 11:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@ElenaStoeva ElenaStoeva force-pushed the snapshot-policy-form/a11y branch from 5150273 to 4cb3c36 Compare October 24, 2023 11:18
alisonelizabeth
alisonelizabeth approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Thanks for fixing this!

Are we also able to unskip some tests as part of this fix? See: #154002

@ElenaStoeva
Copy link
Contributor Author

Thanks for the review @alisonelizabeth! Yes, I didn't notice that the snapshot restore a11y tests are skipped. Unskipped them with 8b288e6.

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) October 27, 2023 10:20
@ElenaStoeva ElenaStoeva merged commit 7ef118c into elastic:main Oct 27, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 259.3KB 259.6KB +299.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 27, 2023
@ElenaStoeva ElenaStoeva deleted the snapshot-policy-form/a11y branch April 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@ElenaStoeva ElenaStoeva

Labels
backport:skip This commit does not require backporting Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y issues on create policy form on snapshot and restore page
5 participants
@ElenaStoeva @elasticmachine @kibana-ci @alisonelizabeth @kibanamachine