Improve Management section accessibility #14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
requested review from
chrisronline,
aphelionz,
cjcenizal and
BigFunger
cjcenizal
approved these changes
Oct 3, 2017
| @@ -13,11 +13,12 @@ | |||
| ></bread-crumbs> | |||
|
|
|||
| <!-- Tabs. --> | |||
| <div data-transclude-slot="bottomRow" class="kuiLocalTabs"> | |||
| <div data-transclude-slot="bottomRow" class="kuiLocalTabs" role="tablist"> | |||
There was a problem hiding this comment.
Do we have issues to apply this role and the other accessibility improvements here to all of the kuiLocalTabs in OSS Kibana and X-Pack?
There was a problem hiding this comment.
Not individual ones I guess, but I can just open another PR right after this one for it.
|
@timroes Could you also add the 7.0.0 and 6.1.0 release labels? |
aphelionz
approved these changes
Oct 4, 2017
timroes
added a commit
that referenced
this pull request
Oct 6, 2017
* Mark tabs in management as such * Add regions to the management section * Add warning as description to the filter input * Make aria-label match placeholder * Rename filter to search in advanced settings
|
Backports:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some accessibility issues in the management UI: