Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Incorporate Advanced Settings Warning into Screen Reader Flow #12873

Closed
aphelionz opened this issue Jul 14, 2017 · 4 comments · Fixed by #14243
Closed

[Accessibility] Incorporate Advanced Settings Warning into Screen Reader Flow #12873

aphelionz opened this issue Jul 14, 2017 · 4 comments · Fixed by #14243
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility

Comments

@aphelionz
Copy link
Contributor

We should find a way to incorporate this warning (at least the warning header) into the screen reader flow.

image

Also, interesting note: There's actually something in the disability community called "The Dignity of Risk" which states that people with disabilities should be allowed to take risks and endanger themselves in the same banal ways that others do. http://www.disabilitypracticeinstitute.com/services/“dignity-of-risk”/

If we can break stuff, they can break stuff too! It's only fair (but they should know the warnings)

@cjcenizal
Copy link
Contributor

@aphelionz "Dignity of risk". I ❤️ this. I think this principle can be extrapolated to all users too. Very often, we're tempted to treat our users like toddlers and put up guardrails by eliminating choices or hiding information because we're afraid of the user making a "bad" choice. But I think we need to take the opposite approach: fully inform the user about the choices they can make, set expectations appropriately, and then let them make bad choices if they desire.

@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@chrisronline
Copy link
Contributor

This doesn't seem trivial. Moving to phase 2

@timroes
Copy link
Contributor

timroes commented Sep 4, 2017

@aphelionz could you shortly explain, why it isn't in the screen reader flow? From what I tested, switching to advanced settings doesn't set your focus somewhere behind the warning, so the screen reader should just come over that warning, before it hits any search box or settings. We could additionally aria-describedby the search input with the warning heading "Caution: You can break stuff here".

@aphelionz
Copy link
Contributor Author

@timroes Adding the aria-describedby is fine, and really all I was getting it. This is much simpler than the discussion made it seem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants