Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Management section accessibility #14243

Merged
merged 5 commits into from
Oct 6, 2017
Merged

Improve Management section accessibility #14243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ddbbb12
Mark tabs in management as such
Oct 2, 2017
3b050d6
Add regions to the management section
Oct 2, 2017
647bdf9
Add warning as description to the filter input
Oct 2, 2017
e9d987a
Make aria-label match placeholder
Oct 2, 2017
29ecbbc
Rename filter to search in advanced settings
Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core_plugins/kibana/public/management/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
></bread-crumbs>

<!-- Tabs. -->
<div data-transclude-slot="bottomRow" class="kuiLocalTabs">
<div data-transclude-slot="bottomRow" class="kuiLocalTabs" role="tablist">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have issues to apply this role and the other accessibility improvements here to all of the kuiLocalTabs in OSS Kibana and X-Pack?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not individual ones I guess, but I can just open another PR right after this one for it.

<h2 class="kuiLocalTab" ng-if="!sectionName" id="tabHeader" tabindex="0">
{{::section.display}}
</h2>
<a
role="tab"
ng-if="sectionName"
ng-repeat="item in section.visibleItems"
class="kuiLocalTab"
Expand All @@ -28,6 +29,8 @@ <h2 class="kuiLocalTab" ng-if="!sectionName" id="tabHeader" tabindex="0">
tooltip-placement="bottom"
tooltip-popup-delay="400"
tooltip-append-to-body="1"
aria-selected="{{!!item.active}}"
aria-disabled="{{!!item.disabled}}"
>
{{::item.display}}
</a>
Expand Down
2 changes: 2 additions & 0 deletions ...gins/kibana/public/management/sections/indices/edit_index_pattern/edit_index_pattern.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
ng-controller="managementIndicesEdit"
data-test-subj="editIndexPattern"
class="kuiViewContent"
role="region"
aria-label="Index pattern details"
>
<!-- Header -->
<kbn-management-index-header
Expand Down
2 changes: 1 addition & 1 deletion src/core_plugins/kibana/public/management/sections/indices/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="col-md-2 sidebar-container">
<div class="col-md-2 sidebar-container" role="region" aria-label="Index patterns">
<div class="sidebar-list">
<div class="sidebar-list-header">
<h5>
Expand Down
2 changes: 1 addition & 1 deletion src/core_plugins/kibana/public/management/sections/objects/_objects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ <h1 class="kuiTitle">
class="kuiToolBarSearchBox__input"
type="text"
placeholder="Search..."
aria-label="Filter"
aria-label="Search"
ng-model="managementObjectsController.advancedFilter"
>
</div>
Expand Down
7 changes: 4 additions & 3 deletions src/core_plugins/kibana/public/management/sections/settings/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="kuiInfoPanel kuiInfoPanel--warning kuiVerticalRhythm">
<div class="kuiInfoPanelHeader">
<span class="kuiInfoPanelHeader__icon kuiIcon kuiIcon--warning fa-bolt"></span>
<span class="kuiInfoPanelHeader__title">
<span class="kuiInfoPanelHeader__title" id="kbnManagementAdvancedWarning">
Caution: You can break stuff here
</span>
</div>
Expand All @@ -30,10 +30,11 @@
<div class="kuiSearchInput__icon kuiIcon fa-search"></div>
<input
class="kuiSearchInput__input"
aria-label="Filter"
aria-label="Search"
ng-model="advancedFilter"
type="text"
placeholder="Filter..."
placeholder="Search..."
aria-describedby="kbnManagementAdvancedWarning"
>
</div>
</form>
Expand Down