[Fleet] Check bundled packages when querying package info in getInfo API #141462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
nchaulet
approved these changes
Sep 22, 2022
|
@nchaulet Added two basic unit tests to cover the fallback and error cases. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2022
…API (elastic#141462) * Check bundled packages when querying package info in getInfo API * Add tests for fetchInfo * Remove needless beforeEach (cherry picked from commit 8774859)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2022
…API (#141462) (#141498) * Check bundled packages when querying package info in getInfo API * Add tests for fetchInfo * Remove needless beforeEach (cherry picked from commit 8774859) Co-authored-by: Kyle Pollich <[email protected]>
This was referenced Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #139567
Check bundled packages on disk for the exact name/version of a given package when requesting packages through the
get package infoFleet API.To test
x-pack/plugins/fleet/targetdirectory (see detailed steps in linked PR)get package infoAPI without a version specifiedcc @sqren