[fleet] Use snapshot registry in dev mode #141797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
nchaulet
reviewed
Sep 26, 2022
| const branch = appContextService.getKibanaBranch(); | ||
| if (branch === 'main') { | ||
| const isProduction = appContextService.getIsProductionMode(); | ||
| if (!isProduction) { |
There was a problem hiding this comment.
should we have both !isProduction || branch === 'main', to get this working on cloud snapshot?
There was a problem hiding this comment.
just checked and looks like on 8.6 cloud snapshot we use the snapshot repository we probably want to keep that
There was a problem hiding this comment.
Updated to check for !isProduction || branch === 'main'
There was a problem hiding this comment.
+1 to this - I think we need the branch === 'main' check here.
sorenlouv
added
the
release_note:skip
nchaulet
approved these changes
Sep 26, 2022
nchaulet
reviewed
Sep 26, 2022
sorenlouv
force-pushed
the
use-snapshot-registry-in-dev-mode
branch
from
88b067d to
ee3c83a
Compare
sorenlouv
force-pushed
the
use-snapshot-registry-in-dev-mode
branch
from
b7583bf to
fb6e2ce
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2022
* [fleet] Use snapshot registry in dev mode * Update registry_url.ts * Update registry_url.ts * Fix jest test (cherry picked from commit e8ebc23)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2022
* [fleet] Use snapshot registry in dev mode * Update registry_url.ts * Update registry_url.ts * Fix jest test (cherry picked from commit e8ebc23) Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #141462
Fixes the error
unable to install apm package 8.5.0. Received status code: 404 and message: [email protected] not found