Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove beta badge for Field statistics table in Discover #140991

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Sep 19, 2022

Summary

This PR removes the beta badge for the Field statistics table.

Screen Shot 2022-09-19 at 12 22 30

Points of consideration for keeping the beta badge:

Points of consideration for removing the beta badge:

  • The field stats table has been available to users since 8.1, and has been in use within ML since 7.x. We should be defining clear criterias for when it can be moved to GA.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 added Feature:Discover Discover Application :ml labels Sep 19, 2022
@qn895 qn895 self-assigned this Sep 19, 2022
@qn895 qn895 requested a review from a team as a code owner September 19, 2022 17:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 added the release_note:feature Makes this part of the condensed release notes label Sep 19, 2022
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, gonna add @ninoslavmiskovic for product review

@peteharverson
Copy link
Contributor

My vote is to leave the beta badge on the field statistics tab for the reasons @qn895 outlined above, specifically until we decide how to integrate the random sampler aggregation into the field statistics table - see #138953.

@kertal
Copy link
Member

kertal commented Sep 26, 2022

My vote is to leave the beta badge on the field statistics tab for the reasons @qn895 outlined above, specifically until we decide how to integrate the random sampler aggregation into the field statistics table - see #138953.

This makes sense, yes 👍

@kertal
Copy link
Member

kertal commented Dec 12, 2022

So #138953 was replaced with #144646, which was merged. added this for visibility

@kertal
Copy link
Member

kertal commented Dec 12, 2022

@peteharverson @qn895 so from your team's perspective we could remove the beta badge? thx!

@peteharverson
Copy link
Contributor

@kertal, yes from the ML point of view, we think the beta badge could be removed for 8.7. The field statistics table in Discover doesn't yet use the random sampler (correct me if I'm wrong @qn895) - #144646 only applied it to the Data Visualizer inside the ML plugin. But I don't think this should stop us removing the beta badge from the field statistics table in Discover.

Are you happy for us to remove it for 8.7 @kertal @ninoslavmiskovic ?

@ninoslavmiskovic
Copy link
Contributor

I am okay with it 👍

@kertal
Copy link
Member

kertal commented Dec 14, 2022

👍 let's do it

@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 14, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 418.4KB 418.1KB -242.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895 qn895 merged commit f6f5ca3 into elastic:main Dec 15, 2022
@qn895 qn895 added the v8.7.0 label Dec 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 15, 2022
@peteharverson peteharverson added release_note:enhancement and removed release_note:feature Makes this part of the condensed release notes labels Feb 1, 2023
@qn895 qn895 deleted the ml-remove-beta-badge branch March 28, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application :ml release_note:enhancement v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants