-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Remove beta badge for Field statistics table in Discover #140991
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, gonna add @ninoslavmiskovic for product review
@peteharverson @qn895 so from your team's perspective we could remove the beta badge? thx! |
@kertal, yes from the ML point of view, we think the beta badge could be removed for 8.7. The field statistics table in Discover doesn't yet use the random sampler (correct me if I'm wrong @qn895) - #144646 only applied it to the Data Visualizer inside the ML plugin. But I don't think this should stop us removing the beta badge from the field statistics table in Discover. Are you happy for us to remove it for 8.7 @kertal @ninoslavmiskovic ? |
I am okay with it 👍 |
👍 let's do it |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @qn895 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
Summary
This PR removes the beta badge for the Field statistics table.
Points of consideration for keeping the beta badge:
Points of consideration for removing the beta badge:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers