Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Use new EuiBetaBadge 'alignment' prop for field statistics tab #147529

Closed
davismcphee opened this issue Dec 14, 2022 · 3 comments
Closed

[Discover] Use new EuiBetaBadge 'alignment' prop for field statistics tab #147529

davismcphee opened this issue Dec 14, 2022 · 3 comments
Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@davismcphee
Copy link
Contributor

Currently we use a custom CSS override to align the EuiBetaBadge in the field statistics tab in Discover. EUI now supports an alignment prop to vertically align the badge, so our custom CSS override is no longer needed: https://elastic.github.io/eui/#/display/badge#beta-badge-type.
Screen Shot 2022-12-14 at 10 17 44 AM
@davismcphee davismcphee added Feature:Discover Discover Application loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week labels Dec 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee mentioned this issue Dec 14, 2022
Closed
@peteharverson
Copy link
Contributor

We have removed the beta badge for the field statistic tab for 8.7.0 in #140991. Are we ok to close this issue @davismcphee or was there any other CSS that was needed here?

@kertal
Copy link
Member

kertal commented Dec 21, 2022

Thx Pete, let's close it!

@kertal kertal closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @peteharverson @elasticmachine @davismcphee