[Discover] New field stats in Discover sidebar popover #139072

jughosta · 2022-08-18T07:35:00Z

Summary

This PR continues the work of integrating field stats (as in Lens popover) into Discover sidebar popover. Previous PR: #136328

Follow up:
#140732
#140733

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…iedFieldList plugin

…ocs'

…plugin

# Conflicts: # src/plugins/discover/kibana.json # src/plugins/discover/public/build_services.ts # x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx # x-pack/plugins/lens/server/routes/index.ts

…r integration tests

jughosta · 2022-09-09T12:08:21Z

src/plugins/unified_field_list/public/components/field_stats/field_stats.tsx

+        message={i18n.translate(
+          'unifiedFieldList.fieldStats.notAvailableForThisFieldWithoutDataDescription',
+          {
+            defaultMessage: `Analysis is not available for this field.`,


@ninoslavmiskovic @gchaps Shall we have a separate message for when data is not available? Currently it also shows "Analysis is not available for this field" but we were also discussing bringing "This field is not available for visualizations because it doesn't have any data." copy. I think it would make sense to extend the copy then with "... for this search criteria" or "... based on sample records" but the copy would become too long. Wdyt?

Perhaps it is implicit, and we can shorten the copy to just say: "This field does not contain any data" ? @gchaps - Wdyt?

@ninoslavmiskovic It can happen that the field has some data but those documents were not a part of the sample. So it would be great to mention why no data: either it's not a part of the sample or it's not present for the current search query/filters.

@jughosta Can you use a different line for each case? For example:

No field data for the current search.
No field data for the current sample.

@gchaps Thanks, that works!

Would it be okay to extend the second line to No field data for the current sample of X records.

I think maybe we can remove the word current and shorten it a bit:

No field data for X sample records.

src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx

src/plugins/unified_field_list/common/utils/field_examples_calculator.ts

…in-discover

kertal · 2022-09-12T09:55:13Z

@elasticmachine merge upstream

…kibana into 135886-field-stats-in-discover

…in-discover

…in-discover # Conflicts: # src/plugins/discover/public/application/main/components/sidebar/discover_field.test.tsx # src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx # src/plugins/discover/public/application/main/components/sidebar/discover_field_visualize.tsx # src/plugins/discover/public/application/main/components/sidebar/discover_sidebar.tsx # x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx

jughosta · 2022-09-14T14:03:50Z

@elasticmachine merge upstream

jughosta · 2022-09-14T14:30:25Z

src/plugins/unified_field_list/common/utils/field_examples_calculator.ts

+
+export const canProvideExamplesForField = (field: DataViewField): boolean => {
+  if (field.name === '_score') {
+    return false;


Created 2 follow up issues:
#140732
#140733

jughosta · 2022-09-14T15:04:09Z

@elasticmachine merge upstream

kertal

Code LGTM, tested locally in Safari, Chrome, Firefox. Great work, it's so much better than our previous implementation! 🥳 All relevant little issues and potential improvements are already in follow up issues. Looking forward to the next steps.

So to merge this it's just the wording of the Advanced settings, then it should be fine

kertal · 2022-09-14T12:48:55Z

src/plugins/unified_field_list/common/utils/field_examples_calculator.ts

+ * Side Public License, v 1.
+ */
+
+// Adapted from src/plugins/discover/public/application/main/components/sidebar/lib/field_calculator.js


hope we can soon get rid of this, the good first issue didn't work so well 😄

…in-discover

jughosta · 2022-09-15T10:45:59Z

@elasticmachine merge upstream

kibana-ci · 2022-09-15T11:24:55Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #27

Test Failures

[job] [logs] FTR Configs #27 / dashboard app - group 1 dashboard embeddable rendering data rendered correctly when dashboard is hard refreshed

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedFieldList`	75	79	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`discover`	78	79	+1
`unifiedFieldList`	52	59	+7
total			+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	470.2KB	471.3KB	+1.1KB
`lens`	1.2MB	1.2MB	-131.0B
`unifiedFieldList`	48.4KB	54.3KB	+6.0KB
total			+6.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	26.3KB	26.5KB	+261.0B
`unifiedFieldList`	6.1KB	6.2KB	+56.0B
total			+317.0B

Unknown metric groups

API count

id	before	after	diff
`discover`	95	96	+1
`unifiedFieldList`	54	61	+7
total			+8

ESLint disabled line counts

id	before	after	diff
`unifiedFieldList`	7	8	+1

Total ESLint disabled count

id	before	after	diff
`unifiedFieldList`	7	8	+1

History

💚 Build #72263 succeeded 011ff80
💔 Build #72228 failed 5151fa8
💚 Build #72138 succeeded 0fec48d
💔 Build #71179 failed 13c82df
💔 Build #70875 failed 8c35550

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

## Summary This PR removes the beta badge for the Field statistics table. <img width="1791" alt="Screen Shot 2022-09-19 at 12 22 30" src="https://user-images.githubusercontent.com/43350163/191076625-9489eaa0-2488-4a5a-b737-e32724d3bffc.png"> Points of consideration for keeping the beta badge: - Easier for us to keep collecting more user feedback. - Potentially switching to [using the new random sampler for aggregation for the field statistics table](#138953) in the next release. Currently, we are pausing this work to match up with the popover (#139072 and #140667) and to fine-tune the user experience/performance. Points of consideration for removing the beta badge: - The field stats table has been available to users since 8.1, and has been in use within ML since 7.x. We should be defining clear criterias for when it can be moved to GA. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

jughosta and others added 30 commits July 13, 2022 16:34

[UnifiedFieldList] Bootstrap a new unifiedFieldList plugin

e6ea7a8

[UnifiedFieldList] Move backend API for field stats from Lens to Unif…

4fe9db0

…iedFieldList plugin

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

68405a5

…ocs'

[Discover] Address CI checks

d46c7a1

[UnifiedFieldList] Move field stats UI from Lens to UnifiedFieldList …

f74243b

…plugin

Merge remote-tracking branch 'upstream/main' into 135886-field-stats

cee3b40

[Discover] Integrate FieldStats into Discover field popover

968454a

[Discover] Show both views side to side

f14fe4c

[Discover] Allow for some customization

116098b

[Discover] Allow for more customization

3243220

[UnifiedFieldList] Remove temporary code

b7e77a3

[UnifiedFieldList] Extract styles

4bac591

Merge branch 'main' into 135886-field-stats

60a3ca9

Merge remote-tracking branch 'upstream/main' into 135886-field-stats

8048325

# Conflicts: # src/plugins/discover/kibana.json # src/plugins/discover/public/build_services.ts # x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx # x-pack/plugins/lens/server/routes/index.ts

[UnifiedFieldList] Fix after merge

c072ed9

[UnifiedFieldList] Extend i18n

5c5f4d2

[UnifiedFieldList] Migrate stats API from server to public

67f0568

[UnifiedFieldList] Update types

3e09343

[UnifiedFieldList] Update Lens tests

ffb9520

[UnifiedFieldList] Update Lens tests

a53242d

[UnifiedFieldList] Before merging

1c989a3

Merge remote-tracking branch 'upstream/main' into 135886-field-stats

6d634e2

[UnifiedFieldList] After merging

e10f286

[UnifiedFieldList] Refactor localization keys

1f8144a

[UnifiedFieldList] Update types

5c9379b

[UnifiedFieldList] Reintroduce server API for field stats and refacto…

f6f8706

…r integration tests

[UnifiedFieldList] Update limits

e4dbbcd

Merge branch 'main' into 135886-field-stats

6f5025b

[UnifiedFieldList] Rename the component

97f5f82

[UnifiedFieldList] Improve types

0e5a2c9

[Discover] Update copy and uncomment console error

473ec1d

jughosta commented Sep 9, 2022

View reviewed changes

kertal reviewed Sep 9, 2022

View reviewed changes

src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx Show resolved Hide resolved

kertal reviewed Sep 9, 2022

View reviewed changes

src/plugins/unified_field_list/common/utils/field_examples_calculator.ts Outdated Show resolved Hide resolved

kertal reviewed Sep 9, 2022

View reviewed changes

src/plugins/unified_field_list/common/utils/field_examples_calculator.ts Outdated Show resolved Hide resolved

jughosta added 2 commits September 9, 2022 16:32

Merge remote-tracking branch 'upstream/main' into 135886-field-stats-…

8c35550

…in-discover

[Discover] Add "no data" message and update field type check in examples

9da4332

Merge branch 'main' into 135886-field-stats-in-discover

13c82df

qn895 approved these changes Sep 13, 2022

View reviewed changes

qn895 mentioned this pull request Sep 13, 2022

[ML] Match Data Visualizer/Field stats table content with the popover #140667

Merged

9 tasks

jughosta added 4 commits September 14, 2022 11:17

Merge branch '135886-field-stats-in-discover' of github.com:jughosta/…

f1fd147

…kibana into 135886-field-stats-in-discover

[Discover] Update type checks and no-data copy

890acef

Merge remote-tracking branch 'upstream/main' into 135886-field-stats-…

0fec48d

…in-discover

Merge branch 'main' into 135886-field-stats-in-discover

5151fa8

jughosta commented Sep 14, 2022

View reviewed changes

Merge branch 'main' into 135886-field-stats-in-discover

011ff80

kertal approved these changes Sep 14, 2022

View reviewed changes

jughosta added 2 commits September 15, 2022 10:24

[Discover] Update copy

2eca3c3

Merge remote-tracking branch 'upstream/main' into 135886-field-stats-…

a401543

…in-discover

Merge branch 'main' into 135886-field-stats-in-discover

b77a6d9

jughosta merged commit cae3a33 into elastic:main Sep 15, 2022

qn895 mentioned this pull request Sep 19, 2022

[ML] Remove beta badge for Field statistics table in Discover #140991

Merged

9 tasks

spalger mentioned this pull request Sep 23, 2022

Failing test: Chrome UI Functional Tests.test/functional/apps/management/_scripted_fields·ts - management scripted fields creating and using Painless date scripted fields should visualize scripted field in vertical bar chart #141616

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] New field stats in Discover sidebar popover #139072

[Discover] New field stats in Discover sidebar popover #139072

jughosta commented Aug 18, 2022 •

edited

Loading

jughosta Sep 9, 2022

ninoslavmiskovic Sep 9, 2022

jughosta Sep 9, 2022

gchaps Sep 13, 2022 •

edited

Loading

jughosta Sep 14, 2022

gchaps Sep 14, 2022

kertal commented Sep 12, 2022

jughosta commented Sep 14, 2022

jughosta Sep 14, 2022

jughosta commented Sep 14, 2022

kertal left a comment •

edited

Loading

kertal Sep 14, 2022

jughosta commented Sep 15, 2022

kibana-ci commented Sep 15, 2022 •

edited

Loading

API count

ESLint disabled line counts

Total ESLint disabled count

[Discover] New field stats in Discover sidebar popover #139072

[Discover] New field stats in Discover sidebar popover #139072

Conversation

jughosta commented Aug 18, 2022 • edited Loading

Summary

Checklist

jughosta Sep 9, 2022

Choose a reason for hiding this comment

ninoslavmiskovic Sep 9, 2022

Choose a reason for hiding this comment

jughosta Sep 9, 2022

Choose a reason for hiding this comment

gchaps Sep 13, 2022 • edited Loading

Choose a reason for hiding this comment

jughosta Sep 14, 2022

Choose a reason for hiding this comment

gchaps Sep 14, 2022

Choose a reason for hiding this comment

kertal commented Sep 12, 2022

jughosta commented Sep 14, 2022

jughosta Sep 14, 2022

Choose a reason for hiding this comment

jughosta commented Sep 14, 2022

kertal left a comment • edited Loading

Choose a reason for hiding this comment

kertal Sep 14, 2022

Choose a reason for hiding this comment

jughosta commented Sep 15, 2022

kibana-ci commented Sep 15, 2022 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

jughosta commented Aug 18, 2022 •

edited

Loading

gchaps Sep 13, 2022 •

edited

Loading

kertal left a comment •

edited

Loading

kibana-ci commented Sep 15, 2022 •

edited

Loading