Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Pass current sort order to fetch more relevant examples in FieldStats for nonaggregatable fields #140732

Closed
Tracked by #166238
jughosta opened this issue Sep 14, 2022 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

jughosta commented Sep 14, 2022

In <FieldStats /> component (inside the sidebar field popover) we fetch only 100 existing documents to build stats for non-aggregatable fields. This request does not include sort param yet. To have better results we should pass current field sorting order from Discover to FieldStats request. This way the examples (shown in the field popover) will match what user sees in the current Discover grid rows.

See buildSearchParams in src/plugins/unified_field_list/common/utils/field_stats_utils.ts

@jughosta jughosta added Feature:Discover Discover Application enhancement New value added to drive a business result loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Oct 22, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants