Exceptions List component #140985

WafaaNasr · 2022-09-19T17:13:09Z

Summary

Created a new Package called @kbn/securitysolution-exception-list-components to hold all the Exception-List components
Adjusted List components to be more generic and accept props so they can be placed on any of the Exception pages
Used @emotion/css, @emotion/react to comply with the kbn-x-packages
used RTL instead of Enzyme

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

WafaaNasr · 2022-09-20T11:42:40Z

yctercero

This is really awesome and making these components generic will clean up a lot of the exceptions code. Now that we're past 8.5 FF, I think it'd be great to move these into a package. Any potential issues with the package, we have plenty of time to address - but also feel free not to do that in this PR if you want to keep things moving.

Thanks so much for all of this. I'm gonna pull down to play around with it, but none of my comments were anything that would block this from going in.

...tion_engine/rule_exceptions/components/list_common/empty_viewer_state/empty_viewer_state.tsx

...tion_engine/rule_exceptions/components/list_common/exception_item_card/comments/comments.tsx

...on_engine/rule_exceptions/components/list_common/exception_item_card/exception_item_card.tsx

.../detection_engine/rule_exceptions/components/list_common/exception_items/exception_items.tsx

...olution/public/detection_engine/rule_exceptions/pages/exception_list_details/translations.ts

...ngine/rule_exceptions/pages/exception_list_details/list_with_search/use_list_with_search.tsx

...ty_solution/public/detection_engine/rule_exceptions/pages/exception_list_details/list_api.ts

..._solution/public/detections/pages/detection_engine/rules/all/exceptions/exceptions_table.tsx

…ons.tsx

WafaaNasr · 2022-09-22T12:55:44Z

@elasticmachine merge upstream

…ic-skeleton

maximpn

@WafaaNasr changes look good but I left some comments related to better typing and simplification which worth to check out.

...engine/rule_exceptions/components/list_common/empty_viewer_state/empty_viewer_state.test.tsx

...tion_engine/rule_exceptions/components/list_common/empty_viewer_state/empty_viewer_state.tsx

...tion_engine/rule_exceptions/components/list_common/exception_item_card/comments/comments.tsx

...ne/rule_exceptions/components/list_common/exception_item_card/conditions/conditions.test.tsx

..._engine/rule_exceptions/components/list_common/exception_item_card/conditions/conditions.tsx

...ptions/components/list_common/exception_item_card/conditions/os_conditions/os_conditions.tsx

...ion_engine/rule_exceptions/components/list_common/exception_item_card/header/header.test.tsx

...ic/detection_engine/rule_exceptions/components/list_common/exception_item_card/meta/meta.tsx

.../detection_engine/rule_exceptions/components/list_common/exception_items/exception_items.tsx

...tion_engine/rule_exceptions/components/list_common/exceptions_utility/exceptions_utility.tsx

WafaaNasr · 2022-09-22T14:56:34Z

@WafaaNasr changes look good but I left some comments related to better typing and simplification which worth to check out.

@maximpn Thanks for the review, Definitely will work on them once I finish moving all the components into a new Package.
As the idea of this PR is to make some existing components generic so we can use them in multiple places as well as apply the new Pattern (separate logic/UI)

…d securityLinkAnchorComponent temp;

elasticmachine · 2022-09-28T05:58:31Z

Pinging @elastic/security-solution (Team: SecuritySolution)

WafaaNasr · 2022-09-28T09:05:51Z

@elasticmachine merge upstream

…ic-skeleton

kibana-ci · 2022-09-28T10:18:36Z

💚 Build Succeeded

Buildkite Build
Commit: fbd4d83

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/securitysolution-exception-list-components`	-	67	+67

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/securitysolution-exception-list-components`	-	1	+1

Unknown metric groups

API count

id	before	after	diff
`@kbn/securitysolution-exception-list-components`	-	76	+76

ESLint disabled line counts

id	before	after	diff
`@kbn/securitysolution-exception-list-components`	-	2	+2

Total ESLint disabled count

id	before	after	diff
`@kbn/securitysolution-exception-list-components`	-	2	+2

History

💚 Build #76297 succeeded af0d816
💚 Build #76123 succeeded 936ed09
💔 Build #76093 failed ea504bc
💔 Build #75910 failed a633535
💔 Build #75889 failed 853cedc
💔 Build #75887 failed 7cc521f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

packages/kbn-securitysolution-exception-list-components/README.md

yctercero

Thanks for addressing my previous comments. This looks really great, and so much cleaner! LGTM 🚀

There's a few TODOs that I can address with some upcoming changes once this is in!

WafaaNasr added release_note:feature Makes this part of the condensed release notes ci:cloud-deploy Create or update a Cloud deployment labels Sep 19, 2022

WafaaNasr self-assigned this Sep 19, 2022

WafaaNasr requested a review from a team as a code owner September 19, 2022 17:13

WafaaNasr requested a review from a team as a code owner September 20, 2022 10:41

WafaaNasr force-pushed the refactor/exception-list-common-component-basic-skeleton branch from 6a5dd70 to ae2dba2 Compare September 20, 2022 12:24

WafaaNasr requested a review from a team as a code owner September 20, 2022 13:33

WafaaNasr requested a review from maximpn September 20, 2022 13:33

WafaaNasr force-pushed the refactor/exception-list-common-component-basic-skeleton branch from 231c0de to fa679db Compare September 20, 2022 14:40

yctercero reviewed Sep 21, 2022

View reviewed changes

WafaaNasr added 9 commits September 22, 2022 09:49

add components with a draft exception-list-details to test

0b07b88

fix jest config in xPack=> security=> Public

b2f8121

fix tests

c3f86c6

fix header test and use RTL

e16c1b4

covert meta test to use RTL and header

90751c1

fix utlity messageid

0e460c0

fix messageid in utilty

f97b206

create osCondition, entryContent and entryContent.helper from Conditi…

d1bf46c

…ons.tsx

comment test until fixing all

2102337

WafaaNasr force-pushed the refactor/exception-list-common-component-basic-skeleton branch from fa0f310 to 2102337 Compare September 22, 2022 07:49

WafaaNasr marked this pull request as draft September 22, 2022 09:48

Merge branch 'main' into refactor/exception-list-common-component-bas…

d680afa

…ic-skeleton

maximpn reviewed Sep 22, 2022

View reviewed changes

WafaaNasr and others added 4 commits September 26, 2022 13:17

create package with first components + test + jest config

86c2ac3

add constants for url

1d0bd61

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

94282c8

disable tests until finishing moving rest of components or fix it+ ad…

1bcf876

…d securityLinkAnchorComponent temp;

WafaaNasr and others added 7 commits September 27, 2022 06:15

add exceptionList-components +fixning build issues

8e9ee1e

add exceptionList-components +fixning build issues

7cc521f

fix translations id + pass comments as props

853cedc

move utiitly out of package until moving all + fixing css

a633535

Merge branch 'main' of github.com:elastic/kibana into pr/140985

6b9cce2

copy non-js/ts files through babel

ea504bc

remove list-details-components

936ed09

WafaaNasr added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team and removed ci:cloud-deploy Create or update a Cloud deployment labels Sep 27, 2022

WafaaNasr added 3 commits September 27, 2022 17:51

apply comments

d2275dc

apply comments in references

af0d816

fix meta tests

3a1c9b2

WafaaNasr marked this pull request as ready for review September 28, 2022 05:58

update tests + add some descriptions

04789cd

Merge branch 'main' into refactor/exception-list-common-component-bas…

fbd4d83

…ic-skeleton

yctercero reviewed Sep 28, 2022

View reviewed changes

packages/kbn-securitysolution-exception-list-components/README.md Outdated Show resolved Hide resolved

WafaaNasr added 2 commits September 28, 2022 19:46

fix camelcase file name in Readme

65f2e0e

fix camelcase file name in Readme

5621dac

yctercero approved these changes Sep 28, 2022

View reviewed changes

WafaaNasr merged commit 77867e1 into elastic:main Sep 28, 2022

WafaaNasr deleted the refactor/exception-list-common-component-basic-skeleton branch September 28, 2022 18:36

kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Sep 28, 2022

spalger mentioned this pull request Sep 28, 2022

[eslint/imports/no-boundary-crossing] don't allow package tests to import outside of packages #142166

Merged

WafaaNasr mentioned this pull request Oct 17, 2022

[Security Solution][Exceptions] - Create/ refactor Exception-List common's components in @kbn/securitysolution-exception-list-components #143363

Merged

3 tasks

elasticmachine unassigned WafaaNasr Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exceptions List component #140985

Exceptions List component #140985

WafaaNasr commented Sep 19, 2022 •

edited

Loading

WafaaNasr commented Sep 20, 2022

yctercero left a comment

WafaaNasr commented Sep 22, 2022

maximpn left a comment

WafaaNasr commented Sep 22, 2022

elasticmachine commented Sep 28, 2022

WafaaNasr commented Sep 28, 2022

kibana-ci commented Sep 28, 2022

API count

ESLint disabled line counts

Total ESLint disabled count

yctercero left a comment

Exceptions List component #140985

Exceptions List component #140985

Conversation

WafaaNasr commented Sep 19, 2022 • edited Loading

Summary

Checklist

WafaaNasr commented Sep 20, 2022

yctercero left a comment

Choose a reason for hiding this comment

WafaaNasr commented Sep 22, 2022

maximpn left a comment

Choose a reason for hiding this comment

WafaaNasr commented Sep 22, 2022

elasticmachine commented Sep 28, 2022

WafaaNasr commented Sep 28, 2022

kibana-ci commented Sep 28, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

ESLint disabled line counts

Total ESLint disabled count

History

yctercero left a comment

Choose a reason for hiding this comment

WafaaNasr commented Sep 19, 2022 •

edited

Loading