[eslint/imports/no-boundary-crossing] don't allow package tests to import outside of packages #142166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/prevent-non-package-deps
branch
2 times, most recently
from
0f129db to
17582f4
Compare
added 2 commits
September 28, 2022 19:27
spalger
force-pushed
the
implement/prevent-non-package-deps
branch
from
17582f4 to
85566ad
Compare
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
WafaaNasr
approved these changes
Sep 29, 2022
jbudz
approved these changes
Sep 29, 2022
kibanamachine
added
v8.6.0
backport:skip
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 2, 2022
…port outside of packages (elastic#142166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #140985 new tests were written in a package that depend on plugin code. This shouldn't have been allowed by our
no_boundary_crossingeslint rule, but it was because the rule previously allowed test code to import anything.This PR splits the
tests or mockssource class intopackage tests or mocksandnon-package tests or mocks.non-package tests or mockscan still import any file.package tests or mockscan only import other packages orpackage tests or mockscode.@WafaaNasr for now I've copied the mocks used into the package. If you'd like to move those mocks to a separate package so they could be used by both the plugin and other packages I'md ask that you do that as a follow up PR.