[Security Solution][Exceptions] - Create/ refactor Exception-List common's components in @kbn/securitysolution-exception-list-components #143363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafaaNasr
added
release_note:feature
|
@elasticmachine merge upstream |
WafaaNasr
changed the title
WafaaNasr
changed the title
WafaaNasr
changed the title
dhurley14
reviewed
Oct 18, 2022
| securityLinkAnchorComponent: ElementType; // This property needs to be removed to avoid the Prop Drilling, once we move all the common components from x-pack/security-solution/common | ||
| } | ||
|
|
||
| export const generateLinedRulesMenuItems = ({ |
There was a problem hiding this comment.
Suggested change
| export const generateLinedRulesMenuItems = ({ | |
| export const generateLinkedRulesMenuItems = ({ |
…Nasr/kibana into common-list-components-pkg
We decided to merge this PR as it is not related to Yara-PR's files |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
kibanamachine
added
v8.6.0
backport:skip
kc13greiner
pushed a commit
to kc13greiner/kibana
that referenced
this pull request
Oct 19, 2022
…mon's components in @kbn/securitysolution-exception-list-components (elastic#143363) * feat: add list header components + refactoring * add tests for comments and conditions components * remove unused var * complete tests for exception_item_card, excpetion_items, empty_viewer_state * add test for useExceptionItemCard hook * add tests for generateLinedRulesMenuItems * add readme and index.md * Update index.md * remove unused file * remove unused file * add tests for Header_menu * extract security mocks to a file * test for header * add missing tests * fix tests * fix text_with_edit dataTestSubj * apply rewview comment Co-authored-by: Kibana Machine <[email protected]>
KOTungseth
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception List component in @kbn/securitysolution-exception-list-components package's changes summary
Continuing from #140985
1. List Header
2. Edit Modal
3. Header Menu
4. Search Bar
5. Exception Item Card
6. Exception Items
7. Pagination
8. EmptyViewerState
a. Empty Search
b. Empty
c. Error
Checklist