Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v62.2.3 #138837

Merged
merged 46 commits into from
Aug 24, 2022
Merged

Upgrade EUI to v62.2.3 #138837

merged 46 commits into from
Aug 24, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 15, 2022

Summary

[email protected][email protected]


62.2.4

Bug fixes

  • Fixed the text size of EuiDescriptionListTitle when EuiDescriptionList is compressed (#6160)

62.2.3

Bug fixes

  • Fixed CollapsedItemActions ref callback not accounting for null value (#6145)

62.2.2

Bug fixes

  • Fixed eui.d.ts containing @testing-library type definitions (#6142)

62.2.1

Bug fixes

  • Fixed server-side rendering and test-env errors caused by useCurrentEuiBreakpoint (#6117)

62.2.0

  • The EuiDataGrid's rowHeightOptions now contain an optional scrollAnchorRow property, which enables vertical layout shift compensation when rendering auto-sized rows. (#6070)
  • Added new React Testing Library EuiToolTip helpers, waitForEuiToolTipVisible and waitForEuiToolTipClose (#6106)

Bug fixes

  • Fixed EuiPortal changes causing rerender issues in test environments (#6105)

62.1.0

  • Updated tokenFile, tokenSymbol and tokenRepo default shapes to square instead of rectangle (#6067)
  • Updated EuiGlobalToastList to be a function component (#6068)
  • Added new useCurrentEuiBreakpoint hook, which returns the current browser window width as a named EUI breakpoint size (e.g. xl) (#6079)

Bug fixes

  • Fixed unintentional subcomponent remounting in EuiCodeBlock during rerenders (#6077)
  • Fixed useIsWithinBreakpoints hook not correctly respecting consumer theme breakpoint overrides (#6079)

CSS-in-JS conversions

  • Converted EuiBreadcrumbs and EuiHeaderBreadcrumbs to Emotion; removed $euiBreadcrumbSpacing and $euiBreadcrumbTruncateWidth (#5934)
  • Converted EuiDescriptionList to Emotion (#5971)
  • Converted EuiToken to Emotion (#6067)
  • Converted EuiToast, EuiGlobalToastList, and EuiGlobalToastListItem to Emotion (#6068)
  • Moved .euiBody-hasPortalContent styles that used to live in _portal.scss to Emotion EuiGlobalStyles (#6075)

@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI v8.5.0 labels Aug 15, 2022
@thompsongl thompsongl changed the title Upgrade EUI to v62.2.0 Upgrade EUI to v62.2.1 Aug 15, 2022
@thompsongl thompsongl changed the title Upgrade EUI to v62.2.1 Upgrade EUI to v62.2.2 Aug 16, 2022
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked Canvas story / snapshot updates, and they look good to me!

@kibana-ci

This comment was marked as outdated.

@thompsongl
Copy link
Contributor Author

@elastic/shared-ux @elastic/ml-ui @elastic/uptime @elastic/apm-ui @paul-tavares
Ready for CODEOWNER reviews!

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes to EuiDescriptionList in ML pages, and LGTM.

Can you add the v62.2.4 change to the PR description and title please.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared-ux changes look good!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1309 1311 +2
ml 1600 1602 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +439.0B
enterpriseSearch 1.6MB 1.6MB -1.0B
ml 3.3MB 3.3MB +437.0B
total +875.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 349.7KB 349.7KB -67.0B
kbnUiSharedDeps-css 470.6KB 451.0KB -19.6KB
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +13.7KB
total -6.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@thompsongl thompsongl merged commit df6392a into elastic:main Aug 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 24, 2022
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Aug 25, 2022
* eui to v62.2.0

* i18n updates

* EuiDescriptionListProps imports

* eui to v62.2.1

* euitoast selector updates

* more EuiDescriptionListProps imports

* eui to v62.2.2

* snapshot updates

* snapshot updates

* toast selector updates

* more snapshot updates

* toast selector

* TRIAL: timeout for loading spinner

* do not assume a popover is closed before attempting to open it again

* Revert "do not assume a popover is closed before attempting to open it again"

This reverts commit 1b23165.

* remove wait

* eui to v62.2.3

* Fixx fleet unit test

* eui to v62.2.4

* snapshot updates

Co-authored-by: Nicolas Chaulet <[email protected]>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
* eui to v62.2.0

* i18n updates

* EuiDescriptionListProps imports

* eui to v62.2.1

* euitoast selector updates

* more EuiDescriptionListProps imports

* eui to v62.2.2

* snapshot updates

* snapshot updates

* toast selector updates

* more snapshot updates

* toast selector

* TRIAL: timeout for loading spinner

* do not assume a popover is closed before attempting to open it again

* Revert "do not assume a popover is closed before attempting to open it again"

This reverts commit 1b23165.

* remove wait

* eui to v62.2.3

* Fixx fleet unit test

* eui to v62.2.4

* snapshot updates

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.