[EuiCodeBlock] Minimize subcomponent remounting #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6077/ |
cee-chen
reviewed
Jul 27, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6077/ |
Co-authored-by: Constance <[email protected]>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6077/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During an investigation of unrelated hook performance, it was found that the copy and fullscreen icons inside
EuiCodeBlockwould be remounted on every rerender. This is because theCopyButton,FullScreenButtoncomponents returned by their respective hooks were not memoized and were being recreated (and therefore unmounted/mounted) every rerender. Similarly,optionalStylesandcodeBlockControlswould unset and recreate their values on every rerender.The net effect of the
useMemoadditions is thatCopyButton,FullScreenButton,FullScreenDisplay,optionalStylesandcodeBlockControlsnow only update on intentional state or prop changes.Checklist