Fix CurrentEuiBreakpoint testenv mocks #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good idea
We can always backport this if we find problems in Kibana |
cee-chen
commented
Aug 9, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6117/ |
thompsongl
approved these changes
Aug 9, 2022
- stopped being an issue after the circular dependency was resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6117/ |
pull bot
pushed a commit
to e-ntro-py/eui
that referenced
this pull request
Aug 15, 2022
* [Misc] Rename current breakpoint files to use snake_casing to match rest of repo * Move out useCurrentEuiBreakpoint hook to separate file to fix testenv behavior * Update changed EuiPageTemplate snapshots as a result of this fix * Fix circular dependency * Fix SSR/typeof undefined issue 🤦 * Revert snapshots - stopped being an issue after the circular dependency was resolved * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@thompsongl your comments in the previous breakpoint PR made me realize I'd also done the
.testenvmock foruseCurrentEuiBreakpointincorrectly. I only mocked the hook itself, but the file also had an exported context and provider component that was missing in our compiledtest-envdirectory.To solve the issue I decided to split the hook out into its own file and only mock that instead of attempting to mock provider logic (as I think that makes sense to leave as-is).
I don't think this affects Kibana since it's unlikely that there's any Kibana usages yet, but let me know if not.
Checklist
yarn build-packand inspect test-env dir- [ ] A changelog entry exists and is marked appropriatelyNot sure if this is needed - thoughts?