Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Set max limit of services back to 500 #131160

Merged

Conversation

MiriamAparicio
Copy link
Contributor

@MiriamAparicio MiriamAparicio commented Apr 28, 2022

Closes #124772

When working on the service groups the limit of services per service group was downed to 50 for performance reason, but this number can be a little low and hide some services that users were seeing before, this PR amends this change.

Following PR will add Kibana configuration option to set this limit to 500 or 50, being 500 the default option.

@MiriamAparicio MiriamAparicio added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 28, 2022
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner April 28, 2022 14:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@MiriamAparicio MiriamAparicio changed the title [APM] set max limit back to 500 [APM] Set max limit back to 500 Apr 28, 2022
@MiriamAparicio MiriamAparicio changed the title [APM] Set max limit back to 500 [APM] Set max limit of services back to 500 Apr 28, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit 6bc515f into elastic:main Apr 29, 2022
@MiriamAparicio MiriamAparicio deleted the set-limit-for-service-groups branch April 29, 2022 13:43
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 131160

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 3, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 131160 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 131160 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 131160 or prevent reminders by adding the backport:skip label.

MiriamAparicio added a commit to MiriamAparicio/kibana that referenced this pull request May 6, 2022
(cherry picked from commit 6bc515f)

# Conflicts:
#	x-pack/plugins/apm/server/routes/services/__snapshots__/queries.test.ts.snap
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2022
MiriamAparicio added a commit that referenced this pull request May 6, 2022
(cherry picked from commit 6bc515f)

# Conflicts:
#	x-pack/plugins/apm/server/routes/services/__snapshots__/queries.test.ts.snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Set soft limit for number of services in the group
5 participants