-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Set soft limit for number of services in the group #124772
Comments
Pinging @elastic/apm-ui (Team:apm) |
@dgieselaar I'm not sure I understand what implications this has. Can you elaborate on what changes if we enforce a "soft limit"? |
The user would not be able to create a group with more than n services,
unless they increase the limit in Kibana's configuration.
Op ma 7 feb. 2022 09:52 schreef Casper Hübertz ***@***.***>:
… @dgieselaar <https://github.com/dgieselaar> I'm not sure I understand
what implications this has. Can you elaborate on what changes if we enforce
a "soft limit"?
—
Reply to this email directly, view it on GitHub
<#124772 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWDXCJFM3HEUANMVH2YKDUZ6B37ANCNFSM5NVD32PQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Can we set the limit to 500 like it is today? That way we won't start hiding services that users can see today. kibana/x-pack/plugins/apm/server/routes/services/get_services/get_services_items.ts Line 18 in f121c54
|
hi team, reading the comments, it's not clear to me which should be the limit 50? or 500? did we agree on something? |
@MiriamAparicio I think 50 is too limiting when considering the use-cases, so following @sqren's proposal of 500 seems more reasonable. |
I'm creating a PR to amend the current max limit from 50 to 500 that will close this issue, and I'll create a new one to add the Kibana configuration option to set this limit |
a couple questions:
|
verified the #131160 |
To prevent performance issues (w/ the terms query), we should set a soft (configurable) limit on the amount of services in each service group. 50 (the number of services on a page) seems like a good start?
The text was updated successfully, but these errors were encountered: