Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Set soft limit for number of services in the group #124772

Closed
dgieselaar opened this issue Feb 6, 2022 · 9 comments · Fixed by #131160
Closed

[APM] Set soft limit for number of services in the group #124772

dgieselaar opened this issue Feb 6, 2022 · 9 comments · Fixed by #131160
Assignees
Labels
apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.3.0

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Feb 6, 2022

To prevent performance issues (w/ the terms query), we should set a soft (configurable) limit on the amount of services in each service group. 50 (the number of services on a page) seems like a good start?

@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Feb 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

@dgieselaar I'm not sure I understand what implications this has. Can you elaborate on what changes if we enforce a "soft limit"?

@dgieselaar
Copy link
Member Author

dgieselaar commented Feb 7, 2022 via email

@sorenlouv
Copy link
Member

Can we set the limit to 500 like it is today? That way we won't start hiding services that users can see today.

@MiriamAparicio
Copy link
Contributor

hi team, reading the comments, it's not clear to me which should be the limit 50? or 500? did we agree on something?
cc @dgieselaar @formgeist

@formgeist
Copy link
Contributor

@MiriamAparicio I think 50 is too limiting when considering the use-cases, so following @sqren's proposal of 500 seems more reasonable.

@MiriamAparicio MiriamAparicio self-assigned this Apr 28, 2022
@MiriamAparicio
Copy link
Contributor

I'm creating a PR to amend the current max limit from 50 to 500 that will close this issue, and I'll create a new one to add the Kibana configuration option to set this limit

@chrisdistasio
Copy link

a couple questions:

  • will there be an impact to the "all services" group? will that "group" be treated the same with a 500 max limit?
  • how will it be determined to show which services if the number of services is > than the set limit?

@kpatticha
Copy link
Contributor

verified the #131160

@kpatticha kpatticha added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-groups apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants