Skip to content

Commit

Permalink
[APM] set max limit back to 500 (#131160) (#131635)
Browse files Browse the repository at this point in the history
(cherry picked from commit 6bc515f)

# Conflicts:
#	x-pack/plugins/apm/server/routes/services/__snapshots__/queries.test.ts.snap
  • Loading branch information
MiriamAparicio authored May 6, 2022
1 parent b4da0e6 commit 1db3281
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/common/service_groups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

export const APM_SERVICE_GROUP_SAVED_OBJECT_TYPE = 'apm-service-group';
export const SERVICE_GROUP_COLOR_DEFAULT = '#D1DAE7';
export const MAX_NUMBER_OF_SERVICES_IN_GROUP = 500;
export const MAX_NUMBER_OF_SERVICE_GROUPS = 500;

export interface ServiceGroup {
groupName: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
ServiceGroup,
SavedServiceGroup,
APM_SERVICE_GROUP_SAVED_OBJECT_TYPE,
MAX_NUMBER_OF_SERVICES_IN_GROUP,
MAX_NUMBER_OF_SERVICE_GROUPS,
} from '../../../common/service_groups';

export async function getServiceGroups({
Expand All @@ -21,7 +21,7 @@ export async function getServiceGroups({
const result = await savedObjectsClient.find<ServiceGroup>({
type: APM_SERVICE_GROUP_SAVED_OBJECT_TYPE,
page: 1,
perPage: MAX_NUMBER_OF_SERVICES_IN_GROUP,
perPage: MAX_NUMBER_OF_SERVICE_GROUPS,
});
return result.saved_objects.map(
({ id, attributes, updated_at: upatedAt }) => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
import { kqlQuery, rangeQuery } from '../../../../observability/server';
import { ProcessorEvent } from '../../../common/processor_event';
import { Setup } from '../../lib/helpers/setup_request';
import { MAX_NUMBER_OF_SERVICES_IN_GROUP } from '../../../common/service_groups';
import { MAX_NUMBER_OF_SERVICE_GROUPS } from '../../../common/service_groups';

export async function lookupServices({
setup,
Expand Down Expand Up @@ -49,7 +49,7 @@ export async function lookupServices({
services: {
terms: {
field: SERVICE_NAME,
size: MAX_NUMBER_OF_SERVICES_IN_GROUP,
size: MAX_NUMBER_OF_SERVICE_GROUPS,
},
aggs: {
environments: {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { ServiceGroup } from '../../../../common/service_groups';

export type ServicesItemsSetup = Setup;

const MAX_NUMBER_OF_SERVICES = 50;
const MAX_NUMBER_OF_SERVICES = 500;

export async function getServicesItems({
environment,
Expand Down

0 comments on commit 1db3281

Please sign in to comment.