-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix links in helper callouts #130873
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , tested a-la-carte
with Safari, MacOs, links are opened in a new window/tab
* [Discover] fix doc explorer link in callout * [Discover] improve the fix Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 2d4ee2e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [Discover] fix doc explorer link in callout * [Discover] improve the fix Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 2d4ee2e) Co-authored-by: Dmitry Tomashevich <[email protected]>
* [Discover] fix doc explorer link in callout * [Discover] improve the fix Co-authored-by: Kibana Machine <[email protected]>
Summary
Fixes #130828
This PR improves links in Discover callouts. Now, links will open new Browser tabs.