Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix links in helper callouts #130873

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Apr 25, 2022

Summary

Fixes #130828

This PR improves links in Discover callouts. Now, links will open new Browser tabs.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0 v8.2.1 labels Apr 25, 2022
@dimaanj dimaanj self-assigned this Apr 25, 2022
@dimaanj
Copy link
Contributor Author

dimaanj commented Apr 25, 2022

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Apr 25, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 407.5KB 407.6KB +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj marked this pull request as ready for review April 26, 2022 05:30
@dimaanj dimaanj requested a review from a team as a code owner April 26, 2022 05:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , tested a-la-carte with Safari, MacOs, links are opened in a new window/tab

@dimaanj dimaanj added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 26, 2022
@dimaanj dimaanj merged commit 2d4ee2e into elastic:main Apr 26, 2022
kibanamachine pushed a commit that referenced this pull request Apr 26, 2022
* [Discover] fix doc explorer link in callout

* [Discover] improve the fix

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2d4ee2e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 27, 2022
* [Discover] fix doc explorer link in callout

* [Discover] improve the fix

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2d4ee2e)

Co-authored-by: Dmitry Tomashevich <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* [Discover] fix doc explorer link in callout

* [Discover] improve the fix

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open document explorer help text link - Learn more in new tab/window
5 participants