Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix links in helper callouts #130873

Merged
merged 4 commits into from
Apr 26, 2022
Merged

[Discover] Fix links in helper callouts #130873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9218f80
[Discover] fix doc explorer link in callout
dimaanj Apr 25, 2022
5eac2c7
[Discover] improve the fix
dimaanj Apr 25, 2022
2d0a260
Merge branch 'main' into fix-doc-explorer-link
kibanamachine Apr 25, 2022
5d58707
Merge branch 'main' into fix-doc-explorer-link
kibanamachine Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ublic/application/main/components/document_explorer_callout/document_explorer_callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const DocumentExplorerCallout = () => {
</EuiButton>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiLink href={docLinks.links.discover.documentExplorer}>
<EuiLink href={docLinks.links.discover.documentExplorer} target="_blank">
<FormattedMessage
id="discover.docExplorerCallout.learnMore"
defaultMessage="Learn more"
Expand Down
4 changes: 2 additions & 2 deletions ...pplication/main/components/document_explorer_callout/document_explorer_update_callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const DocumentExplorerUpdateCallout = () => {
Learn more about the structure of your data with {fieldStatistics}."
values={{
fieldStatistics: (
<EuiLink href={docLinks.links.discover.fieldStatistics} external>
<EuiLink href={docLinks.links.discover.fieldStatistics} target="_blank">
<span css={semiBoldStyle}>
<FormattedMessage
id="discover.docExplorerUpdateCallout.fieldStatistics"
Expand All @@ -82,7 +82,7 @@ export const DocumentExplorerUpdateCallout = () => {
</EuiLink>
),
documentExplorer: (
<EuiLink href={docLinks.links.discover.documentExplorer} external>
<EuiLink href={docLinks.links.discover.documentExplorer} target="_blank">
<span css={semiBoldStyle}>
<FormattedMessage
id="discover.docExplorerUpdateCallout.documentExplorer"
Expand Down