[Security Solution] fix flashing authz on endpoint integration #130933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
kevinlog
approved these changes
Apr 25, 2022
dasansol92
reviewed
Apr 26, 2022
| @@ -106,7 +106,13 @@ export const EndpointPackageCustomExtension = memo<PackageCustomExtensionCompone | |||
| ] | |||
| ); | |||
|
|
|||
| return canAccessEndpointManagement ? artifactCards : <NoPermissions />; | |||
| return loading ? ( | |||
| <EuiLoadingSpinner data-test-subj="endpointExtensionLoadingSpinner" /> | |||
There was a problem hiding this comment.
Could you try using our Management loader instead? Not sure how it will looks under the advanced tab but it should put the loader in the middle of the empty page.
There was a problem hiding this comment.
@dasansol92 We have some code in that component to center the loader on the page because its mean to really be used inside of an entire page.
There was a problem hiding this comment.
That's true, good point!
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
joeypoon
added a commit
to joeypoon/kibana
that referenced
this pull request
Apr 26, 2022
…ic#130933) (cherry picked from commit 823dec2) # Conflicts: # x-pack/plugins/security_solution/public/management/pages/policy/view/ingest_manager_integration/endpoint_package_custom_extension/endpoint_package_custom_extension.test.tsx # x-pack/plugins/security_solution/public/management/pages/policy/view/ingest_manager_integration/endpoint_package_custom_extension/endpoint_package_custom_extension.tsx
joeypoon
added a commit
that referenced
this pull request
Apr 26, 2022
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue where no permissions message flashes on initial load of endpoint integration advanced tab
Issue: #130887
Checklist
For maintainers