Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Rename "APM & Fleet Server" to "Integrations Server" #128574

Merged

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Mar 28, 2022

Summary

Replaces any "APM & Fleet Server" with "Integrations Server"

Fixes #123898

Checklist

Delete any items that are not applicable to this PR.

Notes to reviewers

It wasn't clear to me from https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/GUIDELINE.md what the protocol was to handled translations for an update case. The change seemed fairly simple so I just did the translation on my own.

If that's incorrect, please let me know what the appropriate handling for updating translated strings is. Thanks!

Not sure if I should update or remove them, but the translation seemed straightforward enough, so I just went for it.
@matschaffer matschaffer added release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.0.2 v8.1.2 labels Mar 28, 2022
@matschaffer matschaffer requested a review from simitt March 28, 2022 04:55
@matschaffer matschaffer requested a review from a team as a code owner March 28, 2022 04:55
@matschaffer matschaffer self-assigned this Mar 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@matschaffer matschaffer enabled auto-merge (squash) March 28, 2022 05:44
@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 471.0KB 471.0KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (will test with the snapshot on cloud once it is available)

Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matschaffer matschaffer merged commit 437adb5 into elastic:main Mar 29, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.0 Backport failed because of merge conflicts
8.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.1:
- [CI] Move hourly CI tasks to on merge (#128505)

Manual backport

To create the backport manually run:

node scripts/backport --pr 128574

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128574 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128574 or prevent reminders by adding the backport:skip label.

@spalger spalger removed the v8.0.2 label Apr 1, 2022
@spalger spalger added backport:skip This commit does not require backporting and removed v8.1.2 labels Apr 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
matschaffer added a commit to matschaffer/kibana that referenced this pull request Apr 5, 2022
…r" (elastic#128574)

(cherry picked from commit 437adb5)

# Conflicts:
#	x-pack/plugins/monitoring/dev_docs/how_to/running_components_from_source.md
matschaffer added a commit to matschaffer/kibana that referenced this pull request Apr 5, 2022
…r" (elastic#128574)

(cherry picked from commit 437adb5)

# Conflicts:
#	x-pack/plugins/monitoring/dev_docs/how_to/running_components_from_source.md
matschaffer added a commit that referenced this pull request Apr 5, 2022
…r" (#128574) (#129435)

(cherry picked from commit 437adb5)

# Conflicts:
#	x-pack/plugins/monitoring/dev_docs/how_to/running_components_from_source.md
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Stack Monitoring release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Rename Apm & Fleet Server to Integrations Server
8 participants