Skip to content

Commit

Permalink
[Stack Monitoring] Rename "APM & Fleet Server" to "Integrations Serve…
Browse files Browse the repository at this point in the history
…r" (#128574) (#129435)

(cherry picked from commit 437adb5)

# Conflicts:
#	x-pack/plugins/monitoring/dev_docs/how_to/running_components_from_source.md
  • Loading branch information
matschaffer authored Apr 5, 2022
1 parent 135dd7c commit 07dac54
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import { FormattedMessage } from '@kbn/i18n-react';

// @ts-ignore could not find declaration file
import { MonitoringTimeseriesContainer } from '../chart';
// @ts-ignore could not find declaration file
import { Status } from './instance/status';
import { checkAgentTypeMetric } from '../../lib/apm_agent';

interface TitleType {
Expand Down Expand Up @@ -63,12 +61,12 @@ const getHeading = (isFleetTypeMetric: boolean) => {
const titles: TitleType = {};
if (isFleetTypeMetric) {
titles.title = i18n.translate('xpack.monitoring.apm.metrics.topCharts.agentTitle', {
defaultMessage: 'APM & Fleet Server - Resource Usage',
defaultMessage: 'Integrations Server - Resource Usage',
});
titles.heading = (
<FormattedMessage
id="xpack.monitoring.apm.metrics.agentHeading"
defaultMessage="APM & Fleet Server"
defaultMessage="Integrations Server"
/>
);
return titles;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ const getServerTitle = (isFleetTypeMetric, total) => {
linkLabel.link = (
<FormattedMessage
id="xpack.monitoring.cluster.overview.apmPanel.agentServersTotalLinkLabel"
defaultMessage="APM & Fleet Servers: {apmsTotal}"
defaultMessage="Integrations Servers: {apmsTotal}"
values={{ apmsTotal }}
/>
);
linkLabel.aria = i18n.translate(
'xpack.monitoring.cluster.overview.apmPanel.instancesAndFleetsTotalLinkAriaLabel',
{
defaultMessage: 'APM and Fleet server instances: {apmsTotal}',
defaultMessage: 'Integrations server instances: {apmsTotal}',
values: { apmsTotal },
}
);
Expand All @@ -73,7 +73,7 @@ const getServerTitle = (isFleetTypeMetric, total) => {
const getOverviewTitle = (isFleetTypeMetric) => {
if (isFleetTypeMetric) {
return i18n.translate('xpack.monitoring.cluster.overview.apmPanel.overviewFleetLinkLabel', {
defaultMessage: 'APM & Fleet server overview',
defaultMessage: 'Integrations server overview',
});
}
return i18n.translate('xpack.monitoring.cluster.overview.apmPanel.overviewLinkLabel', {
Expand All @@ -84,7 +84,7 @@ const getOverviewTitle = (isFleetTypeMetric) => {
const getHeadingTitle = (isFleetTypeMetric) => {
if (isFleetTypeMetric) {
return i18n.translate('xpack.monitoring.cluster.overview.apmPanel.apmFleetTitle', {
defaultMessage: 'APM & Fleet server',
defaultMessage: 'Integrations server',
});
}
return i18n.translate('xpack.monitoring.cluster.overview.apmPanel.apmTitle', {
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/monitoring/public/lib/apm_agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
import { Legacy } from '../legacy_shims';

/**
* Possible temporary work arround to establish if APM might also be monitoring fleet:
* https://github.com/elastic/kibana/pull/95129/files#r604815886
* Checks if on cloud and >= 7.13
* In this configuration APM server should be running within elastic agent.
* See https://github.com/elastic/kibana/issues/97879 for details.
*/
export const checkAgentTypeMetric = (versions?: string[]) => {
if (!Legacy.shims.isCloud || !versions) {
Expand Down

0 comments on commit 07dac54

Please sign in to comment.