Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Redesign agent flyout #128381

Merged
merged 21 commits into from
Apr 11, 2022
Merged

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Mar 23, 2022

Summary

Redesign of agent enrollment flyout: #125534

  • Try to enroll a new agent, the new UI should be like this:

Screenshot 2022-03-24 at 18 32 04

Screenshot 2022-03-24 at 18 39 26
Screenshot 2022-03-24 at 18 33 33
Screenshot 2022-04-06 at 17 21 28

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

For maintainers

@joshdover joshdover linked an issue Mar 23, 2022 that may be closed by this pull request
20 tasks
@criamico criamico self-assigned this Mar 23, 2022
@criamico criamico changed the title Agent flyout/refactor flyout [Fleet] Redesign agent flyout Mar 23, 2022
@joshdover
Copy link
Contributor

Submitted a PR to fix a few things here: criamico#1

@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 release_note:enhancement backport:skip This commit does not require backporting labels Mar 24, 2022
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico marked this pull request as ready for review March 24, 2022 17:42
@criamico criamico requested a review from a team as a code owner March 24, 2022 17:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor

juliaElastic commented Mar 28, 2022

I noticed a broken feature in Add agent flyout, with Fleet Server instructions:

  • Create a Fleet Server policy
  • Bug: the created policy doesn't appear in the dropdown
  • Expected: the created Fleet Server policy should appear selected in agent policy dropdown

image

Also, when closing the flyout and navigating to other fleet tabs, I am getting this error:

Error: setSelectedPolicyId is not a function
    at useDefaultAgentPolicyEffect (http://localhost:5620/9007199254740991/bundles/plugin/fleet/kibana/fleet.chunk.0.js:39891:7)

@juliaElastic
Copy link
Contributor

juliaElastic commented Mar 28, 2022

After enrolling a Fleet Server, and opening Add agent flyout, I see failing agent_status queries with this error:

image

Request URL: http://localhost:5620/api/fleet/agent_status/data
Request Method: GET
Status Code: 400 Bad Request
{"statusCode":400,"error":"Bad Request","message":"[request query.agentsIds]: expected at least one defined value but got [undefined]"}

@criamico
Copy link
Contributor Author

@juliaElastic Thanks for testing it out! I'm looking at these issues.

@criamico
Copy link
Contributor Author

criamico commented Mar 28, 2022

@juliaElastic would you mind testing again those issues? I pushed a commit that should fix them.

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@juliaElastic
Copy link
Contributor

@juliaElastic would you mind testing again those issues? I pushed a commit that should fix them.

Thanks, the fleet server enroll flow is fixed now.
I'm still seeing the error with the /agent_status/data call though.

@juliaElastic
Copy link
Contributor

juliaElastic commented Mar 28, 2022

I tested the flow of enrolling agent to Fleet, and I see the UI updated to show that 1 agent has enrolled, and incoming data is confirmed. A few observations:

  • Confirm agent Enrollment step spinner keeps spinning even after agents has been enrolled. Is this expected?
  • The queries to check for agents/agent data keep going on in the background, even after closing the flyout. Is it expected or should it stop at some point?
  • The Confirm incoming data step is called Incoming data confirmed in the original issue, which is the final one? [Fleet] Agent Install Flyout Redesign #125534

image

return (
<EuiText>
<FormattedMessage
id="xpack.fleet.enrollmentInstructions.troubleshootingText"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the troubleshooting link could be extracted to a small component

* @param policyId
* @returns
*/
export const usePollingAgentCount = (policyId: string | undefined) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests are missing, I think you can add them in another pr

@criamico
Copy link
Contributor Author

criamico commented Mar 28, 2022

I tested the flow of enrolling agent to Fleet, and I see the UI updated to show that 1 agent has enrolled, and incoming data is confirmed. A few observations:

  • Confirm agent Enrollment step spinner keeps spinning even after agents has been enrolled. Is this expected?

No, I still have to fix the state of the last two steps and the spinners. I'll check it.

  • The queries to check for agents/agent data keep going on in the background, even after closing the flyout. Is it expected or should it stop at some point?

No it should stop when the flyout closes. It is a bug.

I think it's supposed to be Confirm incoming data when loading and Incoming data confirmed when completed. I'll fix it along with the first point.

Screenshot 2022-03-28 at 14 46 41

@criamico
Copy link
Contributor Author

I pushed a commit where I addressed most of the problems, however I still need to fix the endpoints that keep getting called after closing the panel.

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like after creating one agent, navigating back into the flyout incurs this "empty state" in the dropdown. I think this is similar to the issue @juliaElastic reported above.

image

@juliaElastic
Copy link
Contributor

I noticed that when there is no Fleet Server enrolled initially, there is no way to see the Agent standalone instructions (which doesn't require Fleet Server).
Is this going to be solved by the second part? If so, should the 2 redesigns be included in the same release?
image

@juliaElastic
Copy link
Contributor

juliaElastic commented Mar 29, 2022

It seems like after creating one agent, navigating back into the flyout incurs this "empty state" in the dropdown. I think this is similar to the issue @juliaElastic reported above.

@kpollich I couldn't reproduce this, do you have only one policy in the dropdown? It is expected to have an empty dropdown if you have at least 2 policies (e.g. fleet server policy, agent policy)

@criamico criamico requested a review from joshdover April 11, 2022 10:45
@joshdover
Copy link
Contributor

I know, I also feel that it is confusing for the user since it could prevent the new agents from showing up. This functionality was added after a discussion with @joshdover.
Since it is quite easy to remove and it wasn't explicitly requested by a PM, I would remove it from this PR and later we might reevaluate it.

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

image

Maybe we could enhance this in the future to have 2 separate indicators:

  • One big and obvious success confirmation similar to the one in this PR
  • A smaller indicator / link like "See X other agents enrolled in the last 15 minutes ->"

@joshdover
Copy link
Contributor

BTW feel free to merge without my approval, I may not get to this today.

@juliaElastic
Copy link
Contributor

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

The confirmation will only show up if someone enrolled an agent to the selected agent policy in the last few minutes. That is unlikely to be done by someone else, isn't it?

@juliaElastic
Copy link
Contributor

should the labels be updated to v8.3?

@criamico
Copy link
Contributor Author

IMO it's more confusing to open the flyout and it already have this bright green success UI shown before the user has done anything?

image

Maybe we could enhance this in the future to have 2 separate indicators:

  • One big and obvious success confirmation similar to the one in this PR
  • A smaller indicator / link like "See X other agents enrolled in the last 15 minutes ->"

I think that this piece of functionality needs further investigation and possibly involvement of a PM. It is a good candidate for an enhancement ticket.

@criamico
Copy link
Contributor Author

should the labels be updated to v8.3?

I think they want it merged for 8.2, but I'll check again.

@kpollich
Copy link
Member

kpollich commented Apr 11, 2022

I'm having trouble getting past the "Confirm incoming data" step in Cloud.

I'm enrolling an agent in a basic Agent Policy that just includes the system integration, and I'm running the agent on my Macbook via docker, e.g.

docker run --rm --add-host elasticsearch.local:192.168.65.2 \
  -e FLEET_URL=https://6e3f3c836ed0d22d3db21117a0894f2f.fleet.us-west2.gcp.elastic-cloud.com:443\
  -e FLEET_ENROLL=true \
  -e FLEET_ENROLLMENT_TOKEN=MThjV0JJQUJFTENteXpEd0xBTDI6ZUZSRHpvVmlTUGVPWVFHWkhHTFZ3Zw== \
  docker.elastic.co/beats/elastic-agent:8.2.0-SNAPSHOT

image

My agent starts up as expected, and Fleet reports that it's enrolled, but the "Confirm incoming data" spinner never goes away. I let it sit for 15ish minutes with no change.

Here's what I think is the relevant polling request from my network tab:

/api/fleet/agents?page=1&perPage=20&showInactive=false&showUpgradeable=false
{
    "list": [
        {
            "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
            "access_api_key_id": "t3bDGIABELCmyzDwjYIP",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                "version": "8.2.0"
            },
            "enrolled_at": "2022-04-11T13:15:10Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.2.0-SNAPSHOT (build: 4b4938b6413972b890ea2f8d256b0e066deea109 at 2022-04-07 15:12:02 +0000 UTC)",
                        "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.2.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "6a2804ec7569",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.3/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:03"
                    ],
                    "name": "6a2804ec7569"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "5.10.76-linuxkit",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "b524cbd0-b671-11ec-9278-35137f95496f",
            "type": "PERMANENT",
            "updated_at": "2022-04-11T13:19:22Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:18Z",
            "default_api_key": "uXbDGIABELCmyzDwloJS:0pk0edMnSTeiCyi6CxG14A",
            "default_api_key_id": "uXbDGIABELCmyzDwloJS",
            "policy_output_permissions_hash": "a98b2704d96f3a72c77ee2e499898bc091d3c710d56a7b75c9f7f7b7b0f14f7b",
            "policy_revision_idx": 1,
            "policy_coordinator_idx": 1,
            "policy_revision": 1,
            "status": "online",
            "packages": []
        },
        {
            "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
            "access_api_key_id": "J0tFAYABicK5TYBjdnJC",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                "version": "8.3.0"
            },
            "enrolled_at": "2022-04-06T23:46:11Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.3.0-SNAPSHOT (build: 12eb476712eed1b9b6b94f2b8c807df4ccac3b3b at 2022-04-06 16:14:16 +0000 UTC)",
                        "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.3.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "372f76872ca3",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.99/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:63"
                    ],
                    "name": "372f76872ca3"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "4.15.0-1032-gcp",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "policy-elastic-agent-on-cloud",
            "type": "PERMANENT",
            "default_api_key_id": "FrZMAYABELCmyzDwcwpl",
            "policy_output_permissions_hash": "1c50ec8787bd4cae8cb3e1325361e3ba281f88b698f9c401c0fd7846ff2aefb3",
            "default_api_key": "FrZMAYABELCmyzDwcwpl:_I6_CL8tR7aQ6QJEZcMxhg",
            "policy_revision_idx": 4,
            "policy_coordinator_idx": 1,
            "updated_at": "2022-04-11T13:19:42Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:35Z",
            "policy_revision": 4,
            "status": "online",
            "packages": []
        }
    ],
    "items": [
        {
            "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
            "access_api_key_id": "t3bDGIABELCmyzDwjYIP",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                "version": "8.2.0"
            },
            "enrolled_at": "2022-04-11T13:15:10Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.2.0-SNAPSHOT (build: 4b4938b6413972b890ea2f8d256b0e066deea109 at 2022-04-07 15:12:02 +0000 UTC)",
                        "id": "a7c7bb99-504f-4d4b-bd09-10c2fce9ae1b",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.2.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "6a2804ec7569",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.3/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:03"
                    ],
                    "name": "6a2804ec7569"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "5.10.76-linuxkit",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "b524cbd0-b671-11ec-9278-35137f95496f",
            "type": "PERMANENT",
            "updated_at": "2022-04-11T13:19:22Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:18Z",
            "default_api_key": "uXbDGIABELCmyzDwloJS:0pk0edMnSTeiCyi6CxG14A",
            "default_api_key_id": "uXbDGIABELCmyzDwloJS",
            "policy_output_permissions_hash": "a98b2704d96f3a72c77ee2e499898bc091d3c710d56a7b75c9f7f7b7b0f14f7b",
            "policy_revision_idx": 1,
            "policy_coordinator_idx": 1,
            "policy_revision": 1,
            "status": "online",
            "packages": []
        },
        {
            "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
            "access_api_key_id": "J0tFAYABicK5TYBjdnJC",
            "action_seq_no": [
                -1
            ],
            "active": true,
            "agent": {
                "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                "version": "8.3.0"
            },
            "enrolled_at": "2022-04-06T23:46:11Z",
            "local_metadata": {
                "elastic": {
                    "agent": {
                        "build.original": "8.3.0-SNAPSHOT (build: 12eb476712eed1b9b6b94f2b8c807df4ccac3b3b at 2022-04-06 16:14:16 +0000 UTC)",
                        "id": "d56c6900-ac4d-4798-829d-e60d12753cc7",
                        "log_level": "info",
                        "snapshot": true,
                        "upgradeable": false,
                        "version": "8.3.0"
                    }
                },
                "host": {
                    "architecture": "x86_64",
                    "hostname": "372f76872ca3",
                    "id": "",
                    "ip": [
                        "127.0.0.1/8",
                        "172.17.0.99/16"
                    ],
                    "mac": [
                        "02:42:ac:11:00:63"
                    ],
                    "name": "372f76872ca3"
                },
                "os": {
                    "family": "debian",
                    "full": "Ubuntu focal(20.04.4 LTS (Focal Fossa))",
                    "kernel": "4.15.0-1032-gcp",
                    "name": "Ubuntu",
                    "platform": "ubuntu",
                    "version": "20.04.4 LTS (Focal Fossa)"
                }
            },
            "policy_id": "policy-elastic-agent-on-cloud",
            "type": "PERMANENT",
            "default_api_key_id": "FrZMAYABELCmyzDwcwpl",
            "policy_output_permissions_hash": "1c50ec8787bd4cae8cb3e1325361e3ba281f88b698f9c401c0fd7846ff2aefb3",
            "default_api_key": "FrZMAYABELCmyzDwcwpl:_I6_CL8tR7aQ6QJEZcMxhg",
            "policy_revision_idx": 4,
            "policy_coordinator_idx": 1,
            "updated_at": "2022-04-11T13:19:42Z",
            "last_checkin_status": "online",
            "last_checkin": "2022-04-11T13:19:35Z",
            "policy_revision": 4,
            "status": "online",
            "packages": []
        }
    ],
    "total": 2,
    "totalInactive": 0,
    "page": 1,
    "perPage": 20
}

I do see system/metrics data in my Metrics System Overview dashboard for the agent, and logs in its Logs tab, so I'm not sure what's missing to get past the loader.

@criamico
Copy link
Contributor Author

I'm having trouble getting past the "Confirm incoming data" step in Cloud.

I'm enrolling an agent in a basic Agent Policy that just includes the system integration, and I'm running the agent on my Macbook via docker, e.g.

docker run --rm --add-host elasticsearch.local:192.168.65.2 \
  -e FLEET_URL=https://6e3f3c836ed0d22d3db21117a0894f2f.fleet.us-west2.gcp.elastic-cloud.com:443\
  -e FLEET_ENROLL=true \
  -e FLEET_ENROLLMENT_TOKEN=MThjV0JJQUJFTENteXpEd0xBTDI6ZUZSRHpvVmlTUGVPWVFHWkhHTFZ3Zw== \
  docker.elastic.co/beats/elastic-agent:8.2.0-SNAPSHOT

image

My agent starts up as expected, and Fleet reports that it's enrolled, but the "Confirm incoming data" spinner never goes away. I let it sit for 15ish minutes with no change.

Here's what I think is the relevant polling request from my network tab:

/api/fleet/agents?page=1&perPage=20&showInactive=false&showUpgradeable=false
I do see system/metrics data in my Metrics System Overview dashboard for the agent, and logs in its Logs tab, so I'm not sure what's missing to get past the loader.

Ok, so there's still some problem there. The polling request is similar to this one/api/fleet/agent_status/data?agentsIds=cf852616-61d9-4318-bf9f-fcfb3d72042d and should happen every 5s until some data is retrieved. Here's a short video of the functionality on my local:

Screen.Recording.2022-04-11.at.15.23.43.mov

The other thing that I had to do to see the data is to check that the fleet server host in the settings has the correct IP (http://DOCKERHOST_IP:8220) and I also pass it to the docker command (in addition to your command):

-e FLEET_URL=http://$DOCKERHOST_IP:8220 \

@juliaElastic
Copy link
Contributor

should the labels be updated to v8.3?

I think they want it merged for 8.2, but I'll check again.

I see, even so, v8.3 should be added so that it is merged to main branch as well. v8.2 can remain if this needs to land in 8.2 too.

@criamico
Copy link
Contributor Author

@juliaElastic @kpollich I added a check that should solve the problem with the fail retries in the incoming data component. I'm filtering out agents that have{data: false} in the response to /api/fleet/agent_status/data?agentsIds={agent_ids} query and then I'm setting incomingData to the filtered array; this way it should keep polling until it gets valid data.

@juliaElastic
Copy link
Contributor

@juliaElastic @kpollich I added a check that should solve the problem with the fail retries in the incoming data component. I'm filtering out agents that have{data: false} in the response to /api/fleet/agent_status/data?agentsIds={agent_ids} query and then I'm setting incomingData to the filtered array; this way it should keep polling until it gets valid data.

I tested and the polling works for me now, eventually I see the data confirmed on the flyout.

setIsLoading(false);
// filter out agents that have `data = false` and keep polling
const filtered = data?.items.filter((item) => {
const key = Object.keys(item)[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of multiple agentIds being queried, do they come in separate objects in items array? so we are not missing anything by taking the first key only, right?

Copy link
Contributor Author

@criamico criamico Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there's no problem there, the schema is something like
[ { 'agentid1': { data: true }, { 'agentid2': { data: false }, ... ]

so there's only one key for each item of the array.
Here is where this schema is defined:

agentIdsWithData.includes(id) ? { [id]: { data: true } } : { [id]: { data: false } }

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the review comments

@criamico
Copy link
Contributor Author

criamico commented Apr 11, 2022

LGTM, thanks for fixing the review comments

Thanks a lot for your help! It's better to catch those issues early :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 579 593 +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 684.3KB 692.7KB +8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 110.9KB 110.9KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 6e8d979 into elastic:main Apr 11, 2022
kibanamachine pushed a commit that referenced this pull request Apr 11, 2022
* [Fleet] Redesign and refactor agent flyout

* Further refactoring

* More refactoring and some bug fixing

* bug fixing

* Fix step tests + skip standalone tab tests

* Use test-subj for agent policy code block to fix cypress tests

* Fixing small issues on rendering

* Fix broken import; Fix button in incoming data comp

* Fix loading; add button in incoming data step

* Fix some failures

* Fix tests

* Fix checks

* Address code review comments; add retry logic to incoming data component

* Fix download link

* Check enrolled agents in last 10 minutes

* Filter out agents with data=false from incoming data

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kyle Pollich <[email protected]>
(cherry picked from commit 6e8d979)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 11, 2022
* [Fleet] Redesign and refactor agent flyout

* Further refactoring

* More refactoring and some bug fixing

* bug fixing

* Fix step tests + skip standalone tab tests

* Use test-subj for agent policy code block to fix cypress tests

* Fixing small issues on rendering

* Fix broken import; Fix button in incoming data comp

* Fix loading; add button in incoming data step

* Fix some failures

* Fix tests

* Fix checks

* Address code review comments; add retry logic to incoming data component

* Fix download link

* Check enrolled agents in last 10 minutes

* Filter out agents with data=false from incoming data

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kyle Pollich <[email protected]>
(cherry picked from commit 6e8d979)

Co-authored-by: Cristina Amico <[email protected]>
@criamico criamico deleted the agent_flyout/refactor_flyout branch July 12, 2022 15:00
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed ci:cloud-deploy Create or update a Cloud deployment release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Dynamic "view incoming data" button behaviour [Fleet] Agent Install Flyout Redesign
10 participants